Closed Bug 1551433 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 16762 - [LayoutNG] Check for solid edges for layout opportunities.

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16762 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16762
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[LayoutNG] Check for solid edges for layout opportunities.

Previously we weren't checking for "solid" edges on layout opportunities
within the NGExclusionSpace.

This had the effect of us thinking a particular layout opportunity was
valid (when one edge wasn't against any floats). This caused us to place
the element in such a way that it was "avoiding" a float higher up in
the document (when it shouldn't have).

This introduces a "NGClosedArea" struct, which keeps track of the
"NGEdges" vectors so that before considering a layout opportunity as
valid, we check it has solid edges.

Bug: 959567
Change-Id: If6481a23279eee7a1b188ec4cf5129b503935cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603303
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658748}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/5a156dbce02a [wpt PR 16762] - [LayoutNG] Check for solid edges for layout opportunities., a=testonly

https://hg.mozilla.org/mozilla-central/rev/5a156dbce02a

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.