Closed Bug 1551437 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16782 - [testharness.js] Tolerate late tests

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16782 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16782
Details from upstream follow.

jugglinmike <mike@mikepennisi.com> wrote:

[testharness.js] Tolerate late tests

This reinstates the change originally merged as [1] and subsequently
reverted via [2]. This version of the patch updates the code to pass the
project's linting scripts (by changing the automated test to rely on
step_timeout instead of setTimeout).

[1] 7a02521f636f1c686a73487c3ee9af88ea470a0c
[2] eba8d664eb05a6ca4f7e50fc0e0fa83458ee86cb

@foolip CI failed to catch the linting error in the original submission because neither TravisCI nor Taskcluster ran the lint script. The task was being migrated from TravisCI to Taskcluster at the time. We're not sure if the omission was due to a bug in the Taskcluster configuration or a result of differing merge strategies between the two systems, but neither explanation calls for a fix to the infrastructure.

@jgraham wrote in IRC,

jgraham: I wonder how well tested that patch was

jgraham: Not related to the lint breakage, but related to whether it breaks tests

In acknowledgement of that concern, we should also carefully review the results published to wpt.fyi for this pull request.

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57c1f394870b
[wpt PR 16782] - [testharness.js] Tolerate late tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/57c1f394870b

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.