Closed Bug 1551438 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 16764 - [css-grid] Preserve repeat() notation when serializing declared values

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16764 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16764
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-grid] Preserve repeat() notation when serializing declared values

Before this change, a repeat() notation with an integral number of
repetitions was expanded at parse time. This was observable when reading
declared values using JS APIs.

This patch makes the parser preserve that notation, like it was already
happening when the number of repetitions was automatic and not integral.

The resolved value in getComputedStyle() will still be expanded, though,
as required by the spec.

BUG=716114
TEST=external/wpt/css/css-grid/grid-definition/grid-support-repeat-002.html
TEST=fast/css-grid-layout/grid-element-auto-repeat-get-set.html
TEST=fast/css-grid-layout/named-grid-line-get-set.html

Change-Id: I2d1286bf32aacc9e4fe0b0e8cf14f9f3871d0b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605401
Reviewed-by: Manuel Rego \<rego@igalia.com>
Commit-Queue: Oriol Brufau \<obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#658764}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/904be60f847f [wpt PR 16764] - [css-grid] Preserve repeat() notation when serializing declared values, a=testonly

https://hg.mozilla.org/mozilla-central/rev/904be60f847f

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.