Closed Bug 1551448 Opened 5 years ago Closed 5 years ago

Add linux64-aarch64 and windows10-aarch64 to the platform mapping

Categories

(Tree Management :: Treeherder: Frontend, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: KWierso, Assigned: camd)

References

Details

Attachments

(1 file)

I don't have time to put together the patch, but these two platforms are not getting pretty names applied in the UI because they aren't in the platform mapping file.

Seems like we should fix up all the non-pretty names at the same time we do this. There are a few that have shown up.

Assignee: nobody → cdawson
Priority: -- → P1

Ryan already added these back in May. But I found a few more that need pretty names.

Ryan, can you help me determine what they should be?

Status: NEW → ASSIGNED
Flags: needinfo?(ryanvm)

'windows10-64-ref-hw-2017': 'Windows 10 x64 Ref HW',

My understanding is that this is the 2017 reference hardware we were using for the initial Quantum work. We may want to consider updating the description for this and 'windows10-64-ux' at the same time with something consistent. Maybe "Windows 10 x64 2017 Ref HW" and "Windows 10 x64 2018 Ref HW" ? Maybe Joel can weigh in on this one.

'android-4-0-geckoview-fat-aar': 'Android 4.0 FAT Aar',

Fat AAR is probably the right name here, but Nick would probably know better.

Flags: needinfo?(nalexander)
Flags: needinfo?(jmaher)
Flags: needinfo?(ryanvm)

there is no more windows10-64-ux, that has changed to be windows10-64-ref-hw-2017. I am fine with making that "Windows 10 x64 2017 Ref HW", and when we do add a few devices for the 2018 ref, it would be "Windows 10 x64 2018 Ref HW"

Flags: needinfo?(jmaher)

'android-4-0-geckoview-fat-aar': 'Android 4.0 FAT Aar',

Fat AAR is probably the right name here, but Nick would probably know better.

Let's make sure GeckoView is in the name too, to follow suit with Bug 1563281. NI to gbrown just in case there are interactions.

Can we have

GeckoView multi-arch fat AAR

Also, is this ticket essentially what I was asking for in Bug 1532737?

Flags: needinfo?(nalexander) → needinfo?(gbrown)

In bug 1563281, I do not intend to make any changes to platform labels. For example, "Android 5.0 x86-64 opt" is an accurate description of the associated build, which produces both fennec and geckoview artifacts; "Android 7.0 x86-64 opt" is an accurate description of the associated tests, which run on Android 7.0 and test artifacts from the x86-64 opt build. Individual tests apply to geckoview or fennec, so 1563281 will try to clarify that by adding "geckoview", "fennec", etc to task job names.

I don't object to "Geckoview" being part of the build platform name if the build is geckoview-specific. It might need "Android" first so that the sort order keeps it close to existing "Android" platforms? :camd probably knows.

And yes, it looks like bug 1532737 can be duped to this bug.

Flags: needinfo?(gbrown)

OK, I made those updates to the PR. Nick and Geoff, would you guys give me a thumbs up or down in that PR on getting the naming right? :)

Attachment #9080196 - Flags: review?(nalexander)
Attachment #9080196 - Flags: review?(gbrown)
Comment on attachment 9080196 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5190

Thumbs up. Thanks!
Attachment #9080196 - Flags: review?(gbrown) → review+
Comment on attachment 9080196 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5190

I think with Geoff's thumbs up, I'll call it good.  Please feel free to submit another patch to tweak these further.  :)
Attachment #9080196 - Flags: review?(nalexander)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: