1551468 - [wpt-sync] Sync PR 15140 - [Animation Worklet] Do not allow undefined/NaN local time

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15140 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15140
Details from upstream follow.

Majid Valipour <[e-mail]> wrote:

[Animation Worklet] Do not allow undefined/NaN local time

Restrict localTime type so that NaN is considered invalid which brings us
in line with web-animation.

Our implementation was previously incorrect as it would accept NaN and then
convert it into an unexpected base::TimeDelta.

This patch restricts accepted input by switching EffectProxy.localTime from
'unrestricted double?' -> 'double?' and brings us in line with
ComputedEffectTiming.localTime as defined in Web-Animation. [1,2]

As a side effect the attribute no longer accepts 'undefined'. Per webidl
'double?' is a nullable type which accepts a valid double, or null. So
anywhere we are setting local time to 'undefined' we should use 'null'
instead.

Other changes:

• WorkletAnimation blink/cc are updated to never send NaN
• Update tests to not expect NaN and remove relevant checks
• Add DCHECKS in Animator to ensure local and current times are never NaN
• Update expectations to reflect now working tests

[1] https://drafts.csswg.org/web-animations-1/#dom-computedeffecttiming-localtime
[2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/animation/computed_effect_timing.idl?l=10

Bug: 937456
Change-Id: I9a72e4023608980c8a64743bc6737202e4f70538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1443864
Reviewed-by: Majid Valipour \<[e-mail]>
Reviewed-by: Stephen McGruer \<[e-mail]>
Commit-Queue: Majid Valipour \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#658579}

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d9fd0880abb
[wpt PR 15140] - [Animation Worklet] Do not allow undefined/NaN local time, a=testonly

Comment 2

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4d9fd0880abb

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4d9fd0880abb