Closed Bug 1551472 Opened 5 months ago Closed 4 months ago

Review LoginItem localization with Fluent before exposing it to localization

Categories

(Firefox :: about:logins, task, P2)

task

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: Pike, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [passwords:management] [skyline] )

Attachments

(1 file)

Right now, the login-item element has a huge number of attributes, which really shows a weakness of how we set up DOM element localization in the Fluent bindings.

Once LoginItem is feature-complete, we should review this and see if we can do better. In particular, a few child elements with a slot might help a long way.

Not only would they make the localization easier, but they'd also help in maintaining the element, in case some of its strings need changing or addition. Right now, the whole translation for the element needs to be redone.

Flags: qe-verify-
Priority: -- → P2

In https://phabricator.services.mozilla.com/D30800/, I also speculated about exposing connectRoot, so custom elements could be like "Yeah, I know, we're all modular, but seriously, localize my content like it'd be non-shadow DOM"

Depends on: 1546432
Depends on: 1553176
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90e386cbfa6a
Move localization from being keyed on the custom elements to the elements inside of the shadow roots. r=fluent-reviewers,MattN,Pike
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [passwords:management] [skyline]
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla69 → Firefox 69
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.