1551472 - Review LoginItem localization with Fluent before exposing it to localization

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P2)

Description

[Axel Hecht [:Pike]]

Right now, the login-item element has a huge number of attributes, which really shows a weakness of how we set up DOM element localization in the Fluent bindings.

Once LoginItem is feature-complete, we should review this and see if we can do better. In particular, a few child elements with a slot might help a long way.

Not only would they make the localization easier, but they'd also help in maintaining the element, in case some of its strings need changing or addition. Right now, the whole translation for the element needs to be redone.

Comment 1

[Axel Hecht [:Pike]]

In https://phabricator.services.mozilla.com/D30800/, I also speculated about exposing connectRoot, so custom elements could be like "Yeah, I know, we're all modular, but seriously, localize my content like it'd be non-shadow DOM"

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1551472 - Move localization from being keyed on the custom elements to the elements inside of the shadow roots.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90e386cbfa6a
Move localization from being keyed on the custom elements to the elements inside of the shadow roots. r=fluent-reviewers,MattN,Pike

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/90e386cbfa6a