1551499 - Support Baseline Interpreter code in the profiler

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1551499 - Support Baseline Interpreter code in the profiler. r?djvj!

Because the return address cannot be used to uniquely identify script/pc, this
is unfortunately quite different from what we do for Baseline/Ion code.

The strategy is as follows:

• When the profiler is enabled, ensure each TypeScript has a pointer to the
  profile string (released when the script is finalized).

• This invariant is maintained by releasing all TypeScripts when the profiler
  is enabled and creating these strings for TypeScripts that are on the stack.

• The BaselineInterpreter code is registered with the JitcodeMap.

• The profiler code treats interpreter frames like C++ Interpreter frames,
  instead of doing the return address based mapping.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jandem, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce56e2779818
Support Baseline Interpreter code in the profiler. r=djvj

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ce56e2779818