Closed Bug 1551509 Opened 3 months ago Closed 3 months ago

[BinAST] BinASTTokenReaderBase::{readConst,matchConst} doesn't work for char>=0x80

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

passing const string with char>=0x80 to BinASTTokenReaderBase::{readConst,matchConst} doesn't work as expected because of std::equal with uint8_t* vs char*.

this is problematic because context's magic header contains \x89.

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/b7e30b4bf3f9
Make BinASTTokenReaderBase::{readConst,matchConst} accept char>=0x80. r=Yoric
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.