Closed Bug 1551515 Opened 5 months ago Closed 4 months ago

Library button focused/unfocused when clicking on a abuse report panel's radio button

Categories

(Toolkit :: Add-ons Manager, defect, P1)

68 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: rpl, Assigned: rpl)

References

Details

Attachments

(2 files)

STR:

  • open an abuse report panel for an extension
  • press the mouse left button down (without releasing) on one of the abuse report radio button

Actual result:

  • While the mouse left button is pressed the library button in the Firefox toolbar is marked as focused, and it is unfocused when the mouse button is released

Expected result:

  • pressing the mouse left button on a abuse report panel radio button shouldn't move the focus out of the abuse report panel
Assignee: nobody → lgreco
Blocks: 1540175
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/be82b2bd60e5
Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Verified as fixed in FF 69.0a1 (2019-06-24) using Windows10x64 and macOS 10.13.6

I will attach a postfix video

Status: RESOLVED → VERIFIED
Attached image Postfix video

Do we need this in 68?

Flags: needinfo?(lgreco)

Comment on attachment 9065650 [details]
Bug 1551515 - Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r?mstriemer!

Beta/Release Uplift Approval Request

  • User impact if declined: Without this fix, when a user press the left mouse button down on the body of the abuse report panel, the focus will be wrongly moved from the abuse report panel (part of an about:addons tab) to the Firefox UI (in particular to the library button included in the Firefox toolbar).
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Same steps used to verify it on Nightly.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risky, as issue and the change applied to fix it are restricted to the abuse report panel and its internals.
  • String changes made/needed:
Flags: needinfo?(lgreco)
Attachment #9065650 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9065650 [details]
Bug 1551515 - Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r?mstriemer!

abuse report fix for 68.0b14

Attachment #9065650 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified as fixed in 68.0b14 (64-bit) on Windows 10x64 and macOS 10.13.6

You need to log in before you can comment on or make changes to this bug.