1551515 - Library button focused/unfocused when clicking on a abuse report panel's radio button

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

STR:

• open an abuse report panel for an extension
• press the mouse left button down (without releasing) on one of the abuse report radio button

Actual result:

• While the mouse left button is pressed the library button in the Firefox toolbar is marked as focused, and it is unfocused when the mouse button is released

Expected result:

• pressing the mouse left button on a abuse report panel radio button shouldn't move the focus out of the abuse report panel

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1551515 - Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r?mstriemer!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be82b2bd60e5
Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r=mstriemer

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/be82b2bd60e5

Comment 4

[Victor Carciu]

Verified as fixed in FF 69.0a1 (2019-06-24) using Windows10x64 and macOS 10.13.6

I will attach a postfix video

Comment 5

[Victor Carciu]

Attachment: Postfix video

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Do we need this in 68?

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9065650 [details]
Bug 1551515 - Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r?mstriemer!

Beta/Release Uplift Approval Request

• User impact if declined: Without this fix, when a user press the left mouse button down on the body of the abuse report panel, the focus will be wrongly moved from the abuse report panel (part of an about:addons tab) to the Firefox UI (in particular to the library button included in the Firefox toolbar).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same steps used to verify it on Nightly.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risky, as issue and the change applied to fix it are restricted to the abuse report panel and its internals.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9065650 [details]
Bug 1551515 - Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r?mstriemer!

abuse report fix for 68.0b14

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b7fc852c4c7

Comment 10

[Victor Carciu]

Verified as fixed in 68.0b14 (64-bit) on Windows 10x64 and macOS 10.13.6