1551524 - LookupCache::WriteFile() doesn't correctly report failure

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

https://phabricator.services.mozilla.com/D30046#inline-181894

https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/LookupCache.cpp#113

If StoreToFile fails, we don't correctly report the error upwards but return NS_OK in release mode.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1551524 - Report failure in LookupCache::WriteFile() if StoreToFile returns an error. r?gcp

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c6e5858528a
Report failure in LookupCache::WriteFile() if StoreToFile returns an error. r=gcp

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9c6e5858528a

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Hi Dimi, is there a user impact which justifies backport consideration here or can this fix ride Fx70 to release? Thanks!

Comment 6

[Dimi Lee [:dimi]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Hi Dimi, is there a user impact which justifies backport consideration here or can this fix ride Fx70 to release? Thanks!

Currently I have not yet seen any real bug for this issue, we just found this during code review.
If this happens, the consequence is a bad Safe Browsing database which causes the corresponding feature not work until database is recovered(maybe at the next update).

But since this issue has existed for a long time and we don't see any problem because of it, I would say we don't have to backport this patch.