Closed Bug 1551524 Opened 2 years ago Closed 2 years ago

LookupCache::WriteFile() doesn't correctly report failure

Categories

(Toolkit :: Safe Browsing, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- wontfix
firefox-esr68 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: gcp, Assigned: dimi)

Details

Attachments

(1 file)

Assignee: nobody → dlee
Status: NEW → ASSIGNED
Type: enhancement → defect
Priority: -- → P1
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c6e5858528a
Report failure in LookupCache::WriteFile() if StoreToFile returns an error. r=gcp
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Hi Dimi, is there a user impact which justifies backport consideration here or can this fix ride Fx70 to release? Thanks!

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Hi Dimi, is there a user impact which justifies backport consideration here or can this fix ride Fx70 to release? Thanks!

Currently I have not yet seen any real bug for this issue, we just found this during code review.
If this happens, the consequence is a bad Safe Browsing database which causes the corresponding feature not work until database is recovered(maybe at the next update).

But since this issue has existed for a long time and we don't see any problem because of it, I would say we don't have to backport this patch.

Flags: needinfo?(dlee)
You need to log in before you can comment on or make changes to this bug.