1551533 - TEST-UNEXPECTED-FAIL | [snip]/mozmill/newmailaccount/test-newmailaccount.js

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Looks like most/all subtests of newmailaccount/test-newmailaccount.js fail now.

The pass locally with C-C at tip and some older M-C version, so it's not something we caused.

https://taskcluster-artifacts.net/WkUMGsBpRj6hE1F6Jb9FtA/0/public/logs/live_backing.log
says nice things like:
EXCEPTION: Timed out waiting for search results to arrive.
EXCEPTION: Timeout waiting for the content tab page to load.
EXCEPTION: Timed out waiting for window open!
EXCEPTION: Timeout waiting for window to close!
and also:
EXCEPTION: Not enough arguments [nsIDOMStorageManager.createStorage]

Maybe that's a hint.
M-C last good: e0a622476b7756daebac7ccb7a9bbeb5df
M-C first bad: db99095ae0b53c30927add34be3dc20a7b

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e0a622476b7756daebac7ccb7a9bbeb5df&tochange=db99095ae0b53c30927add34be3dc20a7b

The storage thing looks like:
Andrea Marchesini — Bug 1551055 - StoragePrincipal should be supported by localStorage

If it were an XBL thing, it would be:
Tim Nguyen — Bug 1550561 - Support edit context menu on HTML inputs in chrome documents

Comment 1

[Jorg K (CEST = GMT+2)]

Yes, nsIDOMStorageManager.createStorage() and nsIDOMStorageManager.getStorage() have anther argument now:
https://hg.mozilla.org/mozilla-central/rev/386a0b72c793860f7b40fdf7383b7a9078f02091#l2.19

I'll see where I need to add it.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1551533-createStorage.patch

I'll land this after my local build is done. Maybe it gets r+ first ;-)

Just passing the principal twice should do it, like here:
https://hg.mozilla.org/mozilla-central/rev/386a0b72c793860f7b40fdf7383b7a9078f02091#l27.12

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1551533-createStorage.patch

Oops, another call site, now it all passes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79d2d07d2b9f
Port bug 1551055: Add another parameter to calls of nsIDOMStorageManager.createStorage(). rs=bustage-fix DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

Landed that now so other people doing try runs don't get the oranges.