Closed Bug 1551551 Opened 5 months ago Closed 5 months ago

Fix dependency checking for package.json updates, and fix the scripts to update the builders

Categories

(Firefox Build System :: Lint and Formatting, task, P1)

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Regression)

Details

Attachments

(3 files)

When we landed bug 1495397, we missed telling tools/lint/eslint/setup_helper.py about checking the devDependencies, so currently detecting updates for developer installs has only been working based on the fact I generally update eslint-plugin-mozilla's package.json at the same time as the top-level one.

Additionally, when running the update.sh scripts to update the servers with new node_modules bundles, I'm seeing:

Traceback (most recent call last):
File "./python/mozbuild/mozbuild/action/tooltool.py", line 1304, in <module>
sys.exit(main(sys.argv))
File "./python/mozbuild/mozbuild/action/tooltool.py", line 1301, in main
return 0 if process_command(options, args) else 1
File "./python/mozbuild/mozbuild/action/tooltool.py", line 1188, in process_command
options['unpack'])
File "./python/mozbuild/mozbuild/action/tooltool.py", line 666, in add_files
new_manifest.dump(output, fmt='json')
File "./python/mozbuild/mozbuild/action/tooltool.py", line 534, in dump
print >> output_file, ''
TypeError: unsupported operand type(s) for >>: 'builtin_function_or_method' and 'file'

I have a fix for both of those.

There's also an update to mocha that we use for eslint-plugin-mozilla, so I'd like to grab that at the same time.

See Also: → 1525302
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7a45a6189d2
Fix dependency checking for when to update developer's npm installs. r=ahal
https://hg.mozilla.org/integration/autoland/rev/b392953074b0
Fix tooltool.py use of print in its dump function. r=ahal
https://hg.mozilla.org/integration/autoland/rev/b41a2b516180
Update eslint-plugin-mozilla mocha version (dev dependency). r=ahal
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.