1551583 - [Inactive CSS] Display a warning when list-style-* properties are used incorrectly

Status: RESOLVED WONTFIX

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Only this.style.listStyleType !== "none":

[
  "list-style-image",
]

[This property] doesn't have an effect because list-style-type is set to none. Try adding a property like list-style-type:disc.

Only elements with display:list-item

  "list-style",
  "list-style-image",
  "list-style-position",
  "list-style-type",
  "marker-side",

[This property] doesn't have an effect because display is not set to list-item. Try adding a property like display:list-item

Comment 1

[eduar.mreyes]

Hello, is this bug still relevant? Is someone already working on it? If not, I would like to contribute to taking care of this issue.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

The bug is yours :) Thanks for your help!

Comment 3

[Sebastian Zartner [:sebo]]

Regarding list-style-image it's actually the other way round. When an image is set, it makes list-style-type redundant.

Sebastian

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: Bug 1551583 - New inactive CSS rule to show warning when list-style-type is used on elements with list-style-image. r=ndescottes

Comment 5

[Sebastian Zartner [:sebo]]

Attachment: Bug 1551583 - New inactive CSS rule to show warning when list-style-* is used on non-list-item elements. r=jdescottes

Depends on D101261

Comment 6

[Sebastian Zartner [:sebo]]

Note that marker-side is still [under discussion in the specification] and not implemented in Gecko yet, so I didn't add it for now.

Sebastian

Comment 7

[Sebastian Zartner [:sebo]]

And sorry Eduar, for taking this from you! Though it looks like you didn't have the chance to work on it.

Sebastian

Comment 8

[Daniel Holbert [:dholbert]]

Per my notes in bug 1583901 comment 9 onwards, and the code-comment added in bug 1688538, I think we shouldn't actually add a warning about these properties, because they are inherited-by-default, which makes it hard to reason about whether they're truly inactive (in the element's whole subtree) or not.

Comment 9

[Sebastian Zartner [:sebo]]

Just as a note, there was another reason for marking list-style-type as inactive, as it doesn't have an effect when a marker image is set. Though as it can still serve as a fallback in case the marker image cannot be loaded, so there's not much value in marking it as inactive.

Sebastian