1551601 - Perform cross-process switch before processing cached redirect

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

Processing the cached redirect before processing the cached redirect is not only wrong, but it also interacts badly with the service worker interception.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1551601 - Do process switch _before_ processing cached redirect r=mayhemer

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1551601 - Do process switch _before_ processing cached redirect r=mayhemer

Comment 3

[Nhi Nguyen (:nhi)]

Valentin, is this intended to be uplifted to 68 beta? Please add approval request/flag as appropriate. Thanks!

Comment 4

[Valentin Gosu [:valentin] (he/him)]

(In reply to Nhi Nguyen (:nhi) from comment #3)

Valentin, is this intended to be uplifted to 68 beta? Please add approval request/flag as appropriate. Thanks!

Uplift approval is requested after the patch gets reviewed and usually after it lands on central.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecceef291b89
Do process switch _before_ processing cached redirect r=mayhemer

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/ecceef291b89

Comment 7

[Julien Cristau [:jcristau]]

HTTPResponseProcessSelection was turned off in beta by bug 1554217

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I backed this out in bug 1555966 per Valentin's request to fix the regressions it caused.

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1551601 - When performing a cross process redirect update the loadInfo to have the correct browsingContext r=nika

Depends on D31226

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2719ba46ac12
When performing a cross process redirect update the loadInfo to have the correct browsingContext r=nika

Comment 11

[Narcis Beleuzu [:NarcisB]]

Backed out for causing xpcshell failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/45488fb0fb4fbc279430886edbba4b01a3c63104
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254005156&repo=autoland&lineNumber=1401

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1582b3ffe712
When performing a cross process redirect update the loadInfo to have the correct browsingContext r=nika

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/1582b3ffe712