Closed Bug 1551618 Opened 6 months ago Closed 6 months ago

Add a minimum libclang version check in configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

We can't use the getClangVersion string because that returns a different thing on Mac, but git log libclang.exports llvmorg-3.9.1-rc3..llvmorg-4.0.0 gives a list of APIs introduced only in libclang 4.0 that we could use:

commit 5dda1128f17b6a79740d9f549bac4a3db5d45ac2
Author: Argyrios Kyrtzidis <akyrtzi@gmail.com>
Date:   Thu Dec 1 23:41:27 2016 +0000

    [libclang] Add APIs to check the result of an integer expression in CXEvalResult without overflow
    
    Patch by Emilio Cobos Álvarez!
    See https://reviews.llvm.org/D26788
    
    llvm-svn: 288438

commit b50c55df327cdff661abd5bf4abdabe0370a2989
Author: Cameron Desrochers <cameron@moodycamel.com>
Date:   Thu Aug 18 17:18:03 2016 +0000

    [libclang] Added missing entry for newly introduced 'clang_getAllSkippedRanges' to libclang.exports
    
    llvm-svn: 279092
Assignee: nobody → emilio
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33b8297c53bc
Check for libclang >= 4.0 in configure. r=froydnj
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.