Closed Bug 1551657 Opened 5 months ago Closed 5 months ago

Stop using [array] in password manager idl

Categories

(Toolkit :: Password Manager, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

No description provided.
Summary: Stop using [array in password manager idl → Stop using [array] in password manager idl

There is another consumer outside of the tree which is the Lockwise extension but it doesn't look like it would be broken by these changes as it doesn't use findLogins or searchLogins AFAICT. It shouldn't be a problem for the initial extension release and that code is getting ported in-tree now so won't have to deal with cross-version compatibility in the future.

Priority: -- → P1
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a94b7075dda
part 1.  Stop using [array] in getAllLogins.  r=MattN
https://hg.mozilla.org/integration/autoland/rev/40d655af6177
part 2.  Stop using [array] in getAllDisabledHosts.  r=MattN
https://hg.mozilla.org/integration/autoland/rev/288bafa86adb
part 3.  Stop using [array] in findLogins.  r=MattN
https://hg.mozilla.org/integration/autoland/rev/bdbfb93093ee
part 4.  Stop using [array] in searchLogins.  r=MattN
https://hg.mozilla.org/integration/autoland/rev/bbbbed508f9b
part 5.  Stop using [array] in promptToChangePasswordWithUsernames.  r=MattN

Boris, could you please check C-C usage and CC me on the respective bugs to avoid being hit by something like bug 1552059 (at midnight). Looking at bug 1509981, there are a few more in the works. Four if I count correctly: profiler, places, layout history and controller. Or I could check it now.

I'll try, but for some of these things finding the uses is not trivial (esp. in JS, where the compiler won't catch it for you), and I don't really have time for full c-c audits. You may need to track along and look for c-c JS uses yourself...

As for C++ uses, unfortunately there is no good code-search solution for c-c that will Just Show Them like searchfox does for m-c. Again, I'll see if full-text search shows few enough hits that it's obvious, but no guarantees.

You need to log in before you can comment on or make changes to this bug.