1551710 - hashin shouldn't be used within the project

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Code Cleanup, enhancement)

Description

[Peter Bengtsson [:peterbe]]

It's rare that you need to upgrade Python packages. Soon enough we'll have something like Dependabot doing it for us for small version upgrades.

Today, we built hashin with every build: https://github.com/mozilla/kuma/blob/78cfd85429a7b83d6488f50538537500816ac680/requirements/dev.txt#L37
It's cheap but just yet another thing to maintain and slow us down.

It's documented how to use hashin here.

Comment 1

[Peter Bengtsson [:peterbe]]

By the way, according to pipdeptree this is what hashin brings in:

hashin==0.14.5
  - futures [required: Any, installed: 3.0.5]
  - packaging [required: Any, installed: 17.1]
    - pyparsing [required: >=2.0.2, installed: 2.2.0]
    - six [required: Any, installed: 1.11.0]
  - pip-api [required: Any, installed: 0.0.1]

By looking through all the other dependencies packaging, pyparsing and pip-api are all dragged in because of hashin.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/kuma/pull/5412

Comment 3

[Peter Bengtsson [:peterbe]]

https://github.com/mozilla/kuma/commit/04b7dd1ac522edcbe896ddd89c150f282bb0475b in master