return bool from CallbackTracer and TraceEdgeInternal
Categories
(Core :: JavaScript: GC, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(3 files, 4 obsolete files)
In order to fix bug 1359348, we need to update CallbackTracer (and possibly all its subclasses) to have a method returning bool, to let the callers know whether the edge is swept or moved, .... etc.
And also we will have to update the return value of TraceEdgeInternal.
|
||
Comment 1•5 years ago
|
||
(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh] from comment #0)
a method returning bool, to let the callers know whether the edge is swept or moved, .... etc.
To be clear, this should return whether the edge still exists. And to make it consistent with error-returning functions it should return true in the normal case. So it should return false if the target of the edge was swept, and true at all other times.
|
Assignee | |
Comment 2•5 years ago
|
||
This is just a draft impl to return bool from MovingTracer
|
|
Assignee | |
Comment 3•5 years ago
|
||
This is a draft to dispatch to MovingTracer directly, otherwise I have
to update all CallbackTracers........
Depends on D31424
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
This is for the later patch, to return bool in TraceEdgeInternal.
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Comment 8•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by allstars.chh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4af4586cebba Part 1: return bool in CallbackTracer methods. r=jonco
|
||
Comment 10•5 years ago
|
||
Pushed by allstars.chh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a4233c3962e9 Part 2: return bool in DoCallback. r=jonco
|
|
||
Comment 11•5 years ago
|
||
Pushed by allstars.chh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d6bb5fb30ff5 Part 3: return bool in TraceEdgeInternal. r=jonco
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4af4586cebba
https://hg.mozilla.org/mozilla-central/rev/a4233c3962e9
https://hg.mozilla.org/mozilla-central/rev/d6bb5fb30ff5
Description
•