Closed
Bug 1551824
Opened 7 years ago
Closed 7 years ago
Port Bug 1550770 - Error instead of implicitly converting XPCOM interfaces to builtinclass
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
68
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
3.29 KB,
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
0:56.67 xpidl.xpidl.IDLError: error: scriptable interface 'calIDateTimeLibical' must be marked [builtinclass] because it contains a [notxpcom] method 'toIcalTime', c:/mozilla-source/comm-central/comm/calendar/base/public/calIDateTime.idl line 231:27
0:56.67 [noscript,notxpcom] void toIcalTime(in icaltimetypeptr itt);
|
Assignee | |
Comment 1•7 years ago
|
||
This seems to do it.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/55b2fbbb1f53
mark a few interfaces 'builtinclass' in calendar/ after bug 1550770. rs=bustage-fix DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Target Milestone: --- → 7.0
|
||
Comment 3•7 years ago
|
||
Comment on attachment 9065014 [details] [diff] [review]
1551824-builtinclass.patch
Review of attachment 9065014 [details] [diff] [review]:
-----------------------------------------------------------------
If that works, as you say, then okay.
Attachment #9065014 -
Flags: review?(geoff) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•