Port Bug 1550770 - Error instead of implicitly converting XPCOM interfaces to builtinclass

RESOLVED FIXED in 7.0

Status

defect
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk

Details

Attachments

(1 attachment)

0:56.67 xpidl.xpidl.IDLError: error: scriptable interface 'calIDateTimeLibical' must be marked [builtinclass] because it contains a [notxpcom] method 'toIcalTime', c:/mozilla-source/comm-central/comm/calendar/base/public/calIDateTime.idl line 231:27
0:56.67 [noscript,notxpcom] void toIcalTime(in icaltimetypeptr itt);

This seems to do it.

Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9065014 - Flags: review?(geoff)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/55b2fbbb1f53
mark a few interfaces 'builtinclass' in calendar/ after bug 1550770. rs=bustage-fix DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 7.0
Comment on attachment 9065014 [details] [diff] [review]
1551824-builtinclass.patch

Review of attachment 9065014 [details] [diff] [review]:
-----------------------------------------------------------------

If that works, as you say, then okay.
Attachment #9065014 - Flags: review?(geoff) → review+
You need to log in before you can comment on or make changes to this bug.