1551832 - Onboarding button label not wrapping

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Théo Chevalier]

Attachment: Capture d’écran 2019-05-15 à 11.19.14.png

This label (onboarding-send-tabs-button) doesn’t fit in French, and it looks like it may just be wrapping in two lines instead

Comment 1

[Francesco Lodolo [:flod]]

@mardak
Can we make sure this is evaluated in time for uplifts?

Comment 2

[Ed Lee :Mardak]

What should the behavior be for long button text? I believe aaron (PTO) said buttons stay on one line, so we tried to make sure it expanded wide for longer text, but looks like that's not enough.

Comment 3

[Ed Lee :Mardak]

Looks like at minimum we'll need white-space: pre-wrap to allow multiline fluent strings. Then we'll need to fix up spacing min-height/margin/padding on the button. The button seems to be absolutely positions on the bottom so probably some adjustments needed there too.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5032

Comment 5

[Ed Lee :Mardak]

Just to note here if someone else runs into this when localizing:

Instead of doing:

onboarding-send-tabs-button = Commencer à utiliser « Envoyer l’onglet »

Do this instead:

onboarding-send-tabs-button =
  Commencer à utiliser
  « Envoyer l’onglet »

Bug 1551951 added a localization note noting that buttons can have explicit new lines

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/c7a169c8670c

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly FR locale (68.0a1 Build ID - 20190520095418) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the labels are not exceeding the cards.

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-release/rev/df853c362664989e025d1206b59c37c435186a91