Closed Bug 1551895 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16817 - [LayoutNG] Don't force legacy layout on ::first-letter pseudos.

Categories

(Core :: DOM: Editor, defect, P4)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 16817 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16817
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Don't force legacy layout on ::first-letter pseudos.

Due to the complicated behavior of ::first-letter elements, where the
placement of the ::first-letter DOM node in the DOM tree doesn't
correspond with where we place the LayoutObject in the layout tree, it's
tricky to figure out whether it's part of a subtree that requires us to
force legacy layout or not. So just skip checking. The ::first-letter
element itself can never force legacy layout on its own, so we'll just
do whatever the parent layout object does.

Solution developed together with futhark@chromium.org

Bug: 962090
Change-Id: Ie112561bbd58c0c6f822f500247dbbaa1c8a8118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611602
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659529}

Component: web-platform-tests → Editor
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e36b71d063ed
[wpt PR 16817] - [LayoutNG] Don't force legacy layout on ::first-letter pseudos., a=testonly

https://hg.mozilla.org/mozilla-central/rev/e36b71d063ed

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.