Closed Bug 1551917 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16803 - Reland "[EventTiming] Fix programmatic click test"

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 16803 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16803
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

Reland "[EventTiming] Fix programmatic click test"

This is a reland of 3bd9684c7217ec6229e50ff21c4f905855d7c133

The failure was not getting an entry for click:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/13241

Thus, we instead look at the mousedown. Since mousedown can be the first
input, we stop observing for firstInput but check that entry separately
as well.

Original change's description:

[EventTiming] Fix programmatic click test

Commits aee8357d3fcb0967069d7f72e2f7fab019d61c4e and
faed29aa6dc92cbae6e313b401d23df99e973bc1 landed almost at the same time,
so we accidentally landed a test with the wrong script src for the
helper functions.

Bug: 961547
Change-Id: Id8a615477a54e56139d9d90fc4feb5f780b729a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606225
Reviewed-by: Liquan (Max) Gu \<maxlg@chromium.org>
Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658761}

Bug: 961547
Change-Id: I11f1a5f28e7e4e5ebda28c90555d89669142cc09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610022
Reviewed-by: Liquan (Max) Gu \<maxlg@chromium.org>
Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659680}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/535cd21bcac5
[wpt PR 16803] - Reland "[EventTiming] Fix programmatic click test", a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.