1551929 - Connection::ExecuteAsync seems to make assumptions that may not hold

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The code gets an array of mozIStorageBaseStatement and does this:

    nsCOMPtr<StorageBaseStatementInternal> stmt =
        do_QueryInterface(aStatements[i]);

and then assumes stmt is not null. But there's nothing guaranteeing that. In particular, mozIStorageBaseStatement is not builtinclass, so the caller could be passing a JS implementation.

I suspect that mozIStorageBaseStatement (and mozIStorageAsyncStatement and mozIStorageStatement) should be builtinclass, right?

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Yes. All mozIStorage interfaces should be builtinclass.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1551929. Mark some storage interfaces builtinclass, since we assume there are no JS implementations already. r=asuth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41f28d23024e
Mark some storage interfaces builtinclass, since we assume there are no JS implementations already.  r=asuth

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/41f28d23024e