1551973 - [regression] Reply replies to wrong email, if new message arrived in the meantime (folder changed)

Status: VERIFIED DUPLICATE of bug 1518823

(Thunderbird :: Message Reader UI, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:

• Open a message in a standalone message window
• Read the message
• While you read the message, another message comes into the folder, at the top. E.g. a new message arrived in your inbox. You don't touch the message, or do anything with it, it just arrives in the background.
• Click Reply (in your message reader window)

Actual result:
You get a composer with a reply to the next message, not the one you were reading and where you clicked Reply

Expected result:
You get a composer with a reply to the same message that you are reading.

Importance:
This is a massive interruption in the normal email workflow. If "Reply" doesn't work correctly, just because another message arrived, that's a core feature of the mail program not working correctly and therefore a major bug that needs to be fixed before shipping.

Comment 1

[Ben Bucksch (:BenB)]

This is a regression. I've started seeing that bug only in the last 1-2 months or so.

In the reproduction, I forgot to mention that I have a "newest on top" sort order of my thread pane. That might be relevant to the bug.

This is I think the cause of the bug is that the mail reader window keeps the wrong reference to the mail. It probably keeps an index into the message list (thread pane). Once the list of messages changes, the index of course points to another message. That's an inherent problem - you cannot use an index in this case. You need to keep a reference to the original message object.

Comment 2

[Alice0775 White]

I can reproduce on windows10.

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=4ae0c5713dfecf37275060a0695be6702906adfd&tochange=561033e56bac3a4bf5724ba104d127835db5dfd6
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e49161da578400faf8e938324caff120b95f4863&tochange=cd696bc79dffd9b8f76e1fd924c441ad3d86cbdb

Suspect: Bug 1482389

Comment 3

[Jorg K (CEST = GMT+2)]

Ah, some more fallout from bug 1518823. Please poke Magnus to prioritise that tree work in bug 1518823.

Thanks, Alice, very helpful.

Comment 4

[Ben Bucksch (:BenB)]

VERIFIED FIXED by bug 1518823. Thanks!