1551986 - Do not create unnecessary items inside opacity: 0 containers

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement, P3)

Description

[Miko Mynttinen]

We can now detect which items are needed, instead of building and immediately destroying the unnecessary ones.

Comment 1

[Miko Mynttinen]

Attachment: Bug 1551986 - Do not create unnecessary items inside opacity: 0 containers r=mattwoodrow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a9694ac64f1
Do not create unnecessary items inside opacity: 0 containers r=mattwoodrow

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c5b7adbd1b0
Backed out changeset 8a9694ac64f1 for crashtest failures on nsDisplayList.h CLOSED TREE

Comment 4

[Oana Pop-Rus]

Backed out for crashtest failures on nsDisplayList.h

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=crash%2Ctest&revision=8a9694ac64f199178bea35d73467d23ed7a44feb&selectedJob=246856888

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246856888&repo=autoland&lineNumber=93275

Backout: https://hg.mozilla.org/integration/autoland/rev/2c5b7adbd1b03ca6e2fb36dbe52dba5633a66973

Comment 5

[Miko Mynttinen]

This was unexpected. It seems that we only create nsDisplayTableBlendMode in crashtests, but not in mochi/reftests.
Fixed by marking nsDisplayTableBlendMode container.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/507d95016ed2
Do not create unnecessary items inside opacity: 0 containers r=mattwoodrow

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/507d95016ed2