1552000 - Ensure Raptor Android set_scheduler() is inside the root-required loop

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

It has been brought to my attention in https://bugzilla.mozilla.org/show_bug.cgi?id=1547135#c18 that some developers without rooted device are seeing Raptor fail.

Reorder the tuning commands such that commands requiring root are not run outside of the if/else statement.

Comment 1

[Andrew Creskey [:acreskey]]

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Comment 2

[Edwin Takahashi (:egao | infrequent contributor)]

(In reply to Andrew Creskey from comment #1)

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Might be a case specifically for some devices, but regardless the logic I had in that section of code was unsound. I/O scheduler does require root permission to set but the subroutine was outside of the block that checks if devices has root and/or is rooted.

Comment 3

[Edwin Takahashi (:egao | infrequent contributor)]

Attachment: Bug 1552000 - move root-required tuning commands to its appropriate location for Raptor Android

Comment 4

[Robert Wood [:rwood]]

(In reply to Edwin Gao (:egao) from comment #2)

(In reply to Andrew Creskey from comment #1)

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Might be a case specifically for some devices, but regardless the logic I had in that section of code was unsound. I/O scheduler does require root permission to set but the subroutine was outside of the block that checks if devices has root and/or is rooted.

This just landed yesterday I don't know if it's related?

https://hg.mozilla.org/mozilla-central/rev/d12eb6d840fc2dbbf0746b3dbbbd0ca34352ca75

Comment 5

[Edwin Takahashi (:egao | infrequent contributor)]

(In reply to Robert Wood [:rwood] from comment #4)

(In reply to Edwin Gao (:egao) from comment #2)

(In reply to Andrew Creskey from comment #1)

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Might be a case specifically for some devices, but regardless the logic I had in that section of code was unsound. I/O scheduler does require root permission to set but the subroutine was outside of the block that checks if devices has root and/or is rooted.

This just landed yesterday I don't know if it's related?

https://hg.mozilla.org/mozilla-central/rev/d12eb6d840fc2dbbf0746b3dbbbd0ca34352ca75

It might be related. In my eyes the solution did not require the work you've linked - just shuffling around the set_scheduler() method to under the if root would have done the job.

Either way, the patch to move set_scheduler() to the appropriate place is up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ebc795b98ba
move root-required tuning commands to its appropriate location for Raptor Android r=acreskey

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3ebc795b98ba