Ensure Raptor Android set_scheduler() is inside the root-required loop

RESOLVED FIXED in Firefox 68

Status

defect
P1
normal
RESOLVED FIXED
Last month
Last month

People

(Reporter: egao, Assigned: egao)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last month

It has been brought to my attention in https://bugzilla.mozilla.org/show_bug.cgi?id=1547135#c18 that some developers without rooted device are seeing Raptor fail.

Reorder the tuning commands such that commands requiring root are not run outside of the if/else statement.

Assignee

Updated

Last month
Summary: Ensure Raptor Android tuning commands fail gracefully without root → Ensure Raptor Android set_scheduler() is inside the root-required loop
Assignee

Updated

Last month
Assignee: nobody → egao
Priority: -- → P1

Comment 1

Last month

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Assignee

Comment 2

Last month

(In reply to Andrew Creskey from comment #1)

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Might be a case specifically for some devices, but regardless the logic I had in that section of code was unsound. I/O scheduler does require root permission to set but the subroutine was outside of the block that checks if devices has root and/or is rooted.

(In reply to Edwin Gao (:egao) from comment #2)

(In reply to Andrew Creskey from comment #1)

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Might be a case specifically for some devices, but regardless the logic I had in that section of code was unsound. I/O scheduler does require root permission to set but the subroutine was outside of the block that checks if devices has root and/or is rooted.

This just landed yesterday I don't know if it's related?

https://hg.mozilla.org/mozilla-central/rev/d12eb6d840fc2dbbf0746b3dbbbd0ca34352ca75

Assignee

Comment 5

Last month

(In reply to Robert Wood [:rwood] from comment #4)

(In reply to Edwin Gao (:egao) from comment #2)

(In reply to Andrew Creskey from comment #1)

Hmm... sorry for the noise, on the latest mozilla-central I doesn't look like I have this problem.

i.e. raptor seems to be running fine on non-rooted devices.

Might be a case specifically for some devices, but regardless the logic I had in that section of code was unsound. I/O scheduler does require root permission to set but the subroutine was outside of the block that checks if devices has root and/or is rooted.

This just landed yesterday I don't know if it's related?

https://hg.mozilla.org/mozilla-central/rev/d12eb6d840fc2dbbf0746b3dbbbd0ca34352ca75

It might be related. In my eyes the solution did not require the work you've linked - just shuffling around the set_scheduler() method to under the if root would have done the job.

Either way, the patch to move set_scheduler() to the appropriate place is up.

Comment 6

Last month
Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ebc795b98ba
move root-required tuning commands to its appropriate location for Raptor Android r=acreskey

Comment 7

Last month
bugherder
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.