Closed Bug 1552011 Opened 6 months ago Closed 6 months ago

Ignore newtab component build artifacts

Categories

(Firefox :: Messaging System, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Status
firefox68 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

Attachments

(1 file)

Some build artifacts generated by the newtab component build process/test runner need to be ignored from version control in order for us to support an mc-only work-flow.

This includes:

browser/components/newtab/bin/prerender.js
browser/components/newtab/bin/prerender.js.map
browser/components/newtab/data/locales.json
browser/components/newtab/logs/
Assignee: nobody → khudson

Is there a plan in place to move these away from being within the source directories? I realise this is probably following what debugger does at the moment, but I think we should generally be trying not to.

Flags: needinfo?(khudson)
Pushed by khudson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ab6babfdcee
Ignore newtab component build artifacts r=Mardak,Standard8
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Yes, we have a plan in place to migrate built files away from source directories (as well as build via mach instead of a second command) by the end of 2019 and will be adding new bugs to Bug 1552007 in the near future.

Flags: needinfo?(khudson)
Iteration: --- → 68.4 - Apr 29 - May 12
Priority: -- → P1
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.