Closed Bug 1552059 Opened 1 year ago Closed 1 year ago

Port bug 1551657 part 3. Stop using [array] in findLogins

Categories

(MailNews Core :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch 1552059-findLogins.patch (obsolete) — Splinter Review

This compiles, but the JS part is missing. 2 AM, so over to the NZ night shift.

Attachment #9065267 - Flags: review?(geoff)

Killed commented-out code.

Attachment #9065267 - Attachment is obsolete: true
Attachment #9065267 - Flags: review?(geoff)
Attachment #9065268 - Flags: review?(geoff)

Check I haven't done anything silly.

Attachment #9065271 - Flags: review?(benc)
Attachment #9065268 - Flags: review?(geoff) → review?(benc)
Attachment #9065268 - Flags: review?(benc) → review+
Comment on attachment 9065271 [details] [diff] [review]
1552059-findlogins-js-1.diff

All looks fine (amazed that such a crusty interface lasted so long in M-C!).
xpcshell tests all run fine for me locally.
Attachment #9065271 - Flags: review?(benc) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f2aa9a4e1426
Port bug 1551657: Adapt to array changes of nsILoginManager.findLogins, C++ part. r=benc
https://hg.mozilla.org/comm-central/rev/f0afd7103595
Port bug 1551657: Adapt to array changes of nsILoginManager.findLogins, JS part; r=benc

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
Assignee: nobody → jorgk
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7d081913dbc7
Follow-up: Reformat. rs=reformat
Type: defect → task
You need to log in before you can comment on or make changes to this bug.