1552059 - Port bug 1551657 part 3. Stop using [array] in findLogins

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Jorg K (CEST = GMT+2)]

https://searchfox.org/comm-central/search?q=findLogins&case=false&regexp=false&path=*.cpp

https://searchfox.org/comm-central/search?q=findLogins&case=false&regexp=false&path=*.js

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1552059-findLogins.patch

This compiles, but the JS part is missing. 2 AM, so over to the NZ night shift.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1552059-findLogins.patch (v1b)

Killed commented-out code.

Comment 3

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Attachment: 1552059-findlogins-js-1.diff

Check I haven't done anything silly.

Comment 4

[Ben Campbell]

Comment on attachment 9065271 [details] [diff] [review]
1552059-findlogins-js-1.diff

All looks fine (amazed that such a crusty interface lasted so long in M-C!).
xpcshell tests all run fine for me locally.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f2aa9a4e1426
Port bug 1551657: Adapt to array changes of nsILoginManager.findLogins, C++ part. r=benc
https://hg.mozilla.org/comm-central/rev/f0afd7103595
Port bug 1551657: Adapt to array changes of nsILoginManager.findLogins, JS part; r=benc

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d081913dbc7
Follow-up: Reformat. rs=reformat