Closed Bug 1552077 Opened 1 year ago Closed 1 year ago

use medium high runnables for more image lib runnables

Categories

(Core :: ImageLib, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

I went over all the runnables in imagelib, these were the only ones not touched by bug 1519567 that seemed like they might be important.

Denis was kind enough to run speedindex on a build with this change locally and it showed some nice wins.

speedindex runs show this to be a nice win.

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0649547f4b29
Use medium high runnables for a few more imagelib runnables. r=smaug
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

For reference, here are the numbers I measured from a try build Timothy provided:

pageLoadTime:                                         rev=580d6ced617a         rev=f6e9e020dceb
----------------------------------------------------------------------------------------------------------
www.amazon.com                                    |    912.33 (+-  40)      |   892.22 (+-  81)    2.20% |
www.expedia.com                                   |   3062.00 (+- 412)      |  2509.67 (+- 239)   18.04% |
www.instagram.com-justintimberlake-               |   1710.57 (+- 323)      |  1503.12 (+- 123)   12.13% |
www.reddit.com                                    |   7356.38 (+-1373)      |  7123.78 (+- 874)    3.16% |
www.tripadvisor.com                               |   2794.00 (+- 200)      |  2717.38 (+- 212)    2.74% |
www.twitch.tv                                     |   2052.44 (+-  84)      |  1847.11 (+- 126)   10.00% |
www.youtube.com                                   |   7412.44 (+- 881)      |  6835.75 (+- 485)    7.78% |


PerceptualSpeedIndex:
----------------------------------------------------------------------------------------------------------
www.amazon.com                                    |    925.33 (+-  51)      |   903.56 (+-  71)    2.35% |
www.expedia.com                                   |   2921.78 (+- 228)      |  2495.22 (+- 163)   14.60% |
www.instagram.com-justintimberlake-               |   1033.22 (+-  75)      |   999.11 (+-  65)    3.30% |
www.reddit.com                                    |   3306.56 (+- 328)      |  3026.56 (+- 309)    8.47% |
www.tripadvisor.com                               |   5793.89 (+- 962)      |  5644.22 (+- 271)    2.58% |
www.twitch.tv                                     |   2836.89 (+- 179)      |  2759.33 (+- 154)    2.73% |
www.youtube.com                                   |   6407.56 (+- 147)      |  6425.25 (+- 401)   -0.28% |


SpeedIndex:
----------------------------------------------------------------------------------------------------------
www.amazon.com                                    |    829.00 (+-  45)      |   811.44 (+-  74)    2.12% |
www.expedia.com                                   |   2791.22 (+- 243)      |  2379.33 (+- 183)   14.76% |
www.instagram.com-justintimberlake-               |   1916.11 (+- 166)      |  1814.22 (+- 140)    5.32% |
www.reddit.com                                    |   3341.78 (+- 341)      |  3081.44 (+- 295)    7.79% |
www.tripadvisor.com                               |   6069.44 (+- 968)      |  5882.78 (+- 226)    3.08% |
www.twitch.tv                                     |   2724.33 (+- 209)      |  2577.33 (+- 167)    5.40% |
www.youtube.com                                   |   6281.33 (+- 129)      |  6383.38 (+- 400)   -1.62% |


FirstVisualChange:
----------------------------------------------------------------------------------------------------------
www.amazon.com                                    |    768.89 (+-  39)      |   755.56 (+-  76)    1.73% |
www.expedia.com                                   |    850.00 (+- 126)      |   715.00 (+-  99)   15.88% |
www.instagram.com-justintimberlake-               |    511.11 (+-  39)      |   511.11 (+-  44)    0.00% |
www.reddit.com                                    |   1782.22 (+- 259)      |  1764.44 (+- 347)    1.00% |
www.tripadvisor.com                               |   2335.00 (+- 273)      |  2293.33 (+- 126)    1.78% |
www.twitch.tv                                     |    248.89 (+-  48)      |   266.67 (+-  53)   -7.14% |
www.youtube.com                                   |   6004.44 (+- 149)      |  5980.00 (+- 401)    0.41% |


VisualComplete85:
----------------------------------------------------------------------------------------------------------
www.amazon.com                                    |    768.89 (+-  39)      |   755.56 (+-  76)    1.73% |
www.expedia.com                                   |   4111.11 (+- 359)      |  3471.11 (+- 316)   15.57% |
www.instagram.com-justintimberlake-               |   2453.33 (+- 296)      |  2400.00 (+- 385)    2.17% |
www.reddit.com                                    |   6084.44 (+- 640)      |  5413.33 (+- 453)   11.03% |
www.tripadvisor.com                               |   7680.00 (+- 874)      |  7568.89 (+- 258)    1.45% |
www.twitch.tv                                     |   4662.22 (+- 179)      |  4662.22 (+- 465)    0.00% |
www.youtube.com                                   |   6648.89 (+- 131)      |  6790.00 (+- 455)   -2.12% |
Regressions: 1562135
You need to log in before you can comment on or make changes to this bug.