Closed Bug 1552088 Opened 11 months ago Closed 11 months ago

Port bug 1550816 - Update yaml linting to be consistent with M-C

Categories

(Thunderbird :: Build Config, task)

task
Not set

Tracking

(thunderbird68 fixed, thunderbird69 fixed)

RESOLVED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed

People

(Reporter: rjl, Assigned: rjl)

Details

Attachments

(1 file, 1 obsolete file)

yamllint config:

  • document-start
  • 4-space indentation
  • disable line-length check
Type: defect → task
Update the yamllint configuration to mostly match what M-C is currently using.
Attachment #9065307 - Flags: review?(geoff)
Comment on attachment 9065307 [details] [diff] [review]
Port bug 1550816: Consistent yamllint configuration

Review of attachment 9065307 [details] [diff] [review]:
-----------------------------------------------------------------

If you want to go really mad you can fix the upper-case Y in the last line of all the licence blocks.

TBH I see the yaml linting task broken so often I'm surprised we take any notice of it.

::: .taskcluster.yml
@@ +1,1 @@
>  ---

Licence block?

::: taskcluster/.yamllint
@@ +6,5 @@
>       present: false
>    document-start:
> +     present: true
> +  indentation:
> +     spaces: 4

Is this file even needed after this patch?
Attachment #9065307 - Flags: review?(geoff) → review+
Attached patch 36295.patchSplinter Review

Updated patch.
Added MPL to .taskcluster.yml and .cron.yml

Attachment #9065307 - Attachment is obsolete: true
Attachment #9065591 - Flags: review?(geoff)

(In reply to Geoff Lankow (:darktrojan) from comment #2)

::: taskcluster/.yamllint
Is this file even needed after this patch?

Probably not. I'm leaving it for consistency with M-C.

Attachment #9065591 - Flags: review?(geoff) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8d9eeaf48a30
Port bug 1550816: Consistent yamllint configuration. r=darktrojan

Status: NEW → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0
Comment on attachment 9065591 [details] [diff] [review]
36295.patch

Let's uplift this to join its M-C friend.
Attachment #9065591 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.