Closed Bug 1552108 Opened 7 months ago Closed 7 months ago

about:debugging takes a while to load if ADB process is stopped and USB devices are enabled

Categories

(DevTools :: about:debugging, defect, P1)

defect

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STRs:

  • open about:debugging
  • enable USB devices
  • close about:debugging
  • kill the ADB process (and make sure it doesn't restart automatically, eg kill all Firefox instances)
  • open about:debugging

ER: Should open quickly
AR: Takes a few seconds to open

The about:debugging init waits for the initial runtimes list to be retrieved from ADB, but in case we have to start the ADB process, this can take a while.

We should only wait for the runtimes list if ADB is already started. We should also have a general failsafe (Promise.race + setTimeout 1s ?) to avoid more edge cases blocking the init.

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14d8005e2dd1
Do not wait for runtimes in about:debugging init if ADB not started r=ladybenko
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.