1552109 - Filter count is erroneous when a message is filtered by both text and category

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to data:text/html,<meta charset=utf8><script>console.log("hello"); fetch("https://jsonplaceholder.typicode.com/todos/");</script>
2. Open the console
3. Disable the Log filter
4. Type world in the filter input

Expected results

• The Log button has a (1) next to it.
• The filter bar has a message saying 1 item hidden by filters

Actual results

• The Log button does not have a counter next to it.
• The filter bar has a message saying 2 items hidden by filters

---

That's because in the getMessageVisibility function (devtools/client/webconsole/reducers/messages.js#850-855), we are testing the text filter before the categories filter.

Which mean, we'll include non-default messages that are excluded by the text search, and not show the proper counter on default-category buttons.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1552109 - Fix filter count when text filtering is on. r=bgrins.

The counter was erroneous because we were checking
that messages were validating the text input before
checking if they should be visible based on their
category.
Sadly, mocha tests were asserting that we had a bug,
so we fixed them in this patch.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e5c0606d155
Fix filter count when text filtering is on. r=bgrins.

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8e5c0606d155