1552142 - Text inside the contrast badges should be unselectable

Status: VERIFIED FIXED

(DevTools :: Accessibility Tools, enhancement)

Description

[Timea Cernea [:tbabos][inactive]]

Affected versions
Nightly 68.0a1 (2019-05-15)

Affected platforms
All

Steps to reproduce

• Launch Nightly
• Go to twitter.com (or any other page)
• Enable a11y
• Perform a full page contrast audit
• Hover over the "contrast" badges

Expected result
The text inside the badges should be unselectable and the mouse cursor should not change into the "Text select" form.

Actual Result
The text inside the contrast badges is selectable.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

This requires setting user-select CSS property for the .badge class in https://searchfox.org/mozilla-central/source/devtools/client/accessibility/accessibility.css to none.

Comment 2

[Krishnal Ciccolella]

Hello,

I would like to take a stab at this.

Comment 3

[Krishnal Ciccolella]

Attachment: Bug 1552142 Text inside the contrast badges should be unselectable r=yzen

I added -moz-user-select: none; to the .badge class in devtools/client/accessibility/accessibility.css .

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bab3a664928e
Text inside the contrast badges should be unselectable r=yzen

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bab3a664928e

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Yura, is this something we should nominate for uplift?

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Yura, is this something we should nominate for uplift?

Not crucial. I would just let it ride the train.

Comment 10

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Beta 70.0b7 on Windows 10 64, Mac OS 10.13 and Ubuntu 18.04
Closing it as verified - fixed.