Closed Bug 1552146 Opened 1 year ago Closed 10 months ago

[Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

enhancement

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: miker, Assigned: miker)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Whole tooltip 1px to the right and 2px lower

Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED

We can just stop using the XUL wrapper. We always show the tooltip in the correct place in that case.

I have been over the CSS and positional calculations and they all seem to be correct.

Also, Vertical height is fine on non-retina screens.

Let's see if there is anything we can do to improve accuracy when calculating the rects.

Attached image tooltip-fixed.png

All of our calculations appear to be correct so I have just added offsets to reposition the tooltip.

On hidpi screens the InactiveCSS icon is between pixels so we can't position the tooltip in exactly the right place but with this patch we are as close as we can possibly be.

This patch fixes the issue in both hidpi and non-hidpi modes.

Summary: [Inactive CSS] Move the whole tooltip 1px to the right and 2px lower → [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes
Attachment #9090732 - Attachment description: Bug 1552146 - [Inactive CSS] Move the whole tooltip 1px to the right and 2px lower r=pbro! → Bug 1552146 - [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes r=pbro!
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84708a4f040d
[Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes r=pbro
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1590408
No longer regressions: 1590408
Regressions: 1590408
Attachment #9090732 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.