Closed
Bug 1552146
Opened 5 years ago
Closed 5 years ago
[Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes
Categories
(DevTools :: Inspector: Rules, enhancement, P2)
DevTools
Inspector: Rules
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
377.90 KB,
image/png
|
Details |
Whole tooltip 1px to the right and 2px lower
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
We can just stop using the XUL wrapper. We always show the tooltip in the correct place in that case.
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
I have been over the CSS and positional calculations and they all seem to be correct.
Also, Vertical height is fine on non-retina screens.
Let's see if there is anything we can do to improve accuracy when calculating the rects.
Assignee | ||
Comment 4•5 years ago
|
||
All of our calculations appear to be correct so I have just added offsets to reposition the tooltip.
On hidpi screens the InactiveCSS icon is between pixels so we can't position the tooltip in exactly the right place but with this patch we are as close as we can possibly be.
This patch fixes the issue in both hidpi and non-hidpi modes.
Assignee | ||
Updated•5 years ago
|
Summary: [Inactive CSS] Move the whole tooltip 1px to the right and 2px lower → [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes
Updated•5 years ago
|
Attachment #9090732 -
Attachment description: Bug 1552146 - [Inactive CSS] Move the whole tooltip 1px to the right and 2px lower r=pbro! → Bug 1552146 - [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes r=pbro!
Assignee | ||
Comment 5•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5f8fa55dde1d5727aef170bfc07bc9cd1f87ec5
Assignee | ||
Comment 6•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a69b6e49c36b127ea464fc08c7a5e2e0c703b4f9
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84708a4f040d [Inactive CSS] Fine tune the tooltip's position in hidpi and non-hidpi modes r=pbro
Comment 8•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•4 years ago
|
Attachment #9090732 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•