Closed Bug 1552160 Opened 1 year ago Closed 1 year ago

Update security/sandbox/chromium/ to Chromium commit 84108231f6e6e0772fb9a4643679ce76aa771e67.

Categories

(Core :: Security: Process Sandboxing, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

(Regressed 1 open bug)

Details

Attachments

(13 files, 24 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
2.59 KB, text/plain
Details

Update security/sandbox/chromium/ to latest Chromium stable channel version once Fx69 is on m-c.
This should be chromium 74.
The way the dates work here mean that we might need to take some minor release patches as well.

Blocks: 1552706

Depends on D31824

Originally landed as changset:
https://hg.mozilla.org/mozilla-central/rev/adb1d2a92e0d

Depends on D31828

We don't currently make use of it and it brings in many dependencies.

Depends on D31829

This is basically a revert of chromium commit 996b42db5296bd3d11b3d7fde1a4602bbcefed2c.

Depends on D31830

This basically reverts chromium commit 569193665184525ca366e65d0735f5c851106e43.

Depends on D31831

This brings in new dependencies via FilePath and we don't currently use it.
As far as I can tell Chromium doesn't use it either.

Depends on D31832

This has a dependency on nspr, which causes issues.

Originally landed in changeset:
https://hg.mozilla.org/mozilla-central/rev/477b991bf6fa7b4511768649c9bf37c7275d30d9

Depends on D31833

This also changes the read only related status checks in filesystem_interception.cc to include STATUS_NETWORK_OPEN_RESTRICTION (0xC0000201), which gets returned in some cases and fails because we never ask the broker.

Depends on D31835

The GCC case includes a stray \ at the end of the line that gcc
complains about.

For reference purposes, this commit is a combination of Bug 1431621
and Bug 1432790 combined together so that it looks like I hadn't
screwed it up.

Depends on D31837

Depends on D31838

MozReview-Commit-ID: GCKj5Ao2Y2n

Depends on D31839

error: invalid conversion from 'FARPROC {aka int (attribute((stdcall)) )()}' to 'void' [-fpermissive]

According to http://stackoverflow.com/questions/13958081/, msvc does the fixup

Depends on D31840

This function is a technique to name a thread for debugging purposes,
and it always throws an exception (and then continues). On MinGW
we don't want it to throw an exception, so we do nothing.

This means on MinGW we won't get nice thread naming during debugging,
but we'll limp along.

MozReview-Commit-ID: JRKY4wp7sdu

Depends on D31842

MozReview-Commit-ID: D7REZiAIMpN

Depends on D31843

Attached file Bug 1552160. (obsolete) —

Depends on D31845

Hook this into the browser via the XREAppData. This patch contains only the changes to Chromium source code.

Originally landed in changeset:
https://hg.mozilla.org/mozilla-central/rev/6ecd19d25822

Depends on D31853

Allows the creation/use of temp files when the user has already green-lit
the use of a file for write purposes in that folder.

Originally landed in changeset:
https://hg.mozilla.org/mozilla-central/rev/0f64b24c40c4

Depends on D31854

Some notes for the added chromium/base and chromium-shim/base files.

Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/370c40e49230
Part 1: Roll-up of chromium sandbox update and mozilla patches to get a running browser. r=jld,aklotz,tjr,bobowen
https://hg.mozilla.org/integration/mozilla-inbound/rev/c627801eeecc
Part 2: Roll-up patch to apply remaining mozilla changes to chromium sandbox. r=tabraldes,aklotz,jimm,bobowen
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

This ended up being an update to commit 84108231f6e6e0772fb9a4643679ce76aa771e67 not a95171383423bed8840d49a9247debb426bf705d.

84108231f6e6e0772fb9a4643679ce76aa771e67 was the Chromium commit for the last release of Chrome 74 and there were no changes that affected the files we take between a95171383423bed8840d49a9247debb426bf705d and 84108231f6e6e0772fb9a4643679ce76aa771e67.

Summary: Update security/sandbox/chromium/ to Chromium commit a95171383423bed8840d49a9247debb426bf705d. → Update security/sandbox/chromium/ to Chromium commit 84108231f6e6e0772fb9a4643679ce76aa771e67.
Attachment #9066161 - Attachment is obsolete: true
Attachment #9066160 - Attachment is obsolete: true
Attachment #9066159 - Attachment is obsolete: true
Attachment #9066158 - Attachment is obsolete: true
Attachment #9066157 - Attachment is obsolete: true
Attachment #9066156 - Attachment is obsolete: true
Attachment #9066151 - Attachment is obsolete: true
Attachment #9066149 - Attachment is obsolete: true
Attachment #9066148 - Attachment is obsolete: true
Attachment #9066147 - Attachment is obsolete: true
Attachment #9066146 - Attachment is obsolete: true
Attachment #9066145 - Attachment is obsolete: true
Attachment #9066144 - Attachment is obsolete: true
Attachment #9066142 - Attachment is obsolete: true
Attachment #9066140 - Attachment is obsolete: true
Attachment #9066139 - Attachment is obsolete: true
Attachment #9066138 - Attachment is obsolete: true
Attachment #9066137 - Attachment is obsolete: true
Attachment #9066136 - Attachment is obsolete: true
Attachment #9066134 - Attachment is obsolete: true
Attachment #9066133 - Attachment is obsolete: true
Attachment #9066132 - Attachment is obsolete: true
Attachment #9066131 - Attachment is obsolete: true
Attachment #9066130 - Attachment is obsolete: true
Regressions: 1564899
Regressions: 1564904
Regressions: 1565848
You need to log in before you can comment on or make changes to this bug.