1552168 - Remove pref security.data_uri.unique_opaque_origin

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P2)

Description

[Christoph Kerschbaumer [:ckerschb]]

Introduced while developing within Bug 1324406 it's not needed any longer.

Comment 1

[Sebastian Streich [:sstreich]]

Attachment: Bug 1552168 - Remove Pref data_uri.unique_opaque_origin r=ckerschb

Comment 2

[Sebastian Streich [:sstreich]]

Attachment: Bug 1552168 - Fix Tests that rely on data_uri.unique_opaque_origin r=ckerschb

Depends on D35005

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ff83cc5d33a
Remove Pref data_uri.unique_opaque_origin r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/83590619ce06
Fix Tests that rely on data_uri.unique_opaque_origin r=ckerschb

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/33ed51dffab880869136c544d864cbd7736ee7f7

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=254580371&resultStatus=testfailed%2Cbusted%2Cexception&revision=83590619ce06e66e9be3a1593da824d53cf97415

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=254580371&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=254580370&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=254586708&repo=autoland

Sebastian Streich can you please take a look?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There are several more failures in crashtests and mochitest plain. Check the failures for this push which ran all jobs: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=254584712&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=cab912119d7999d329e3cb06f15ad780547fa119

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:sstreich, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Sebastian Streich [:sstreich]]

Sorry, i probably won't have time to get the patches landed. There were wierd test failures that probably require whole tests to be re-written as they are based on data uri's not beeing opaque.

Comment 9

[Christoph Kerschbaumer [:ckerschb]]

Besides the obvious tests that need to be updated - let's see what else is falling apart with that change:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=09e30deb1ef9d090ee1e13e8efbb709866d88e7f

Comment 10

[Christoph Kerschbaumer [:ckerschb]]

I guess this one should be almost what we want:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf03f4b7cc809022a095c52b3cff2ee6c35c54e8

Comment 11

[Christoph Kerschbaumer [:ckerschb]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4292ef660b05e8ccc366c205570739c9941fd6ca

Comment 12

[Christoph Kerschbaumer [:ckerschb]]

I don't understand why we have different failures now :-(
https://treeherder.mozilla.org/#/jobs?repo=try&revision=450af1f1bb796dd1acc5a8b7bac7d7c18883d04c

Comment 13

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1552168: Remove pref security.data_uri.unique_opaque_origin. r=smaug

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6606fce124f9
Remove pref security.data_uri.unique_opaque_origin. r=smaug

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6606fce124f9