1552199 - List of created records does not include records from dump on first sync

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, defect, P1)

Description

[Mathieu Leplatre [:leplatrem]]

If an event listener only treats additions (ie. ignores current), then the records that come from the dump will never be handled.

On the first sync, the list of created records should contain both the ones from the dump and the ones obtain from the sync.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1552199 - Include records from dump in Remote Settings sync event created data

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6519e3500428
Include records from dump in Remote Settings sync event created data r=glasserc

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 6519e3500428 (Bug 1552199) for test_remote_settings.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=4a73759aafa6f3168453b2765f9b13e5fdc640d3&fromchange=6519e35004283dc67e83ce49090480c724fac5bf&selectedJob=247364277

Backout link: https://hg.mozilla.org/integration/autoland/rev/4a73759aafa6f3168453b2765f9b13e5fdc640d3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247364277&repo=autoland&lineNumber=1392

[task 2019-05-20T15:28:57.354Z] 15:28:57 INFO - SUITE-START | Running 1 tests
[task 2019-05-20T15:28:57.978Z] 15:28:57 INFO - TEST-START | services/settings/test/unit/test_remote_settings.js
[task 2019-05-20T15:29:32.169Z] 15:29:32 WARNING - TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_remote_settings.js | xpcshell return code: 0
[task 2019-05-20T15:29:32.170Z] 15:29:32 INFO - TEST-INFO took 34191ms

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a57a160207c4
Include records from dump in Remote Settings sync event created data r=glasserc

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a57a160207c4