List of created records does not include records from dump on first sync

RESOLVED FIXED in Firefox 69

Status

()

defect
P1
normal
RESOLVED FIXED
Last month
Last month

People

(Reporter: leplatrem, Assigned: leplatrem)

Tracking

unspecified
Firefox 69
Points:
---

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

If an event listener only treats additions (ie. ignores current), then the records that come from the dump will never be handled.

On the first sync, the list of created records should contain both the ones from the dump and the ones obtain from the sync.

Assignee

Updated

Last month
Assignee: nobody → mathieu

Comment 2

Last month
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6519e3500428
Include records from dump in Remote Settings sync event created data r=glasserc

Backed out changeset 6519e3500428 (Bug 1552199) for test_remote_settings.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=4a73759aafa6f3168453b2765f9b13e5fdc640d3&fromchange=6519e35004283dc67e83ce49090480c724fac5bf&selectedJob=247364277

Backout link: https://hg.mozilla.org/integration/autoland/rev/4a73759aafa6f3168453b2765f9b13e5fdc640d3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247364277&repo=autoland&lineNumber=1392

[task 2019-05-20T15:28:57.354Z] 15:28:57 INFO - SUITE-START | Running 1 tests
[task 2019-05-20T15:28:57.978Z] 15:28:57 INFO - TEST-START | services/settings/test/unit/test_remote_settings.js
[task 2019-05-20T15:29:32.169Z] 15:29:32 WARNING - TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_remote_settings.js | xpcshell return code: 0
[task 2019-05-20T15:29:32.170Z] 15:29:32 INFO - TEST-INFO took 34191ms

Flags: needinfo?(mathieu)

Comment 4

Last month
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a57a160207c4
Include records from dump in Remote Settings sync event created data r=glasserc

Comment 5

Last month
bugherder
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Assignee

Updated

Last month
Flags: needinfo?(mathieu)
You need to log in before you can comment on or make changes to this bug.