Closed
Bug 1552362
Opened 5 years ago
Closed 5 years ago
DLL Interceptor: ADRP decoding should treat imm offset as signed
Categories
(Core :: mozglue, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla69
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
Right now we're treating it like it's unsigned, so we might not always decode the correct address.
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/592cf7293093 Ensure that the DLL Interceptor's ADRP decoding treats its immediate operand as signed; r=handyman
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9065562 [details]
Bug 1552362: Ensure that the DLL Interceptor's ADRP decoding treats its immediate operand as signed; r=handyman!
Beta/Release Uplift Approval Request
- User impact if declined: Potential for crashes/failures on ARM64
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple, straightforward patch
- String changes made/needed:
Attachment #9065562 -
Flags: approval-mozilla-beta?
Comment 5•5 years ago
|
||
Comment on attachment 9065562 [details]
Bug 1552362: Ensure that the DLL Interceptor's ADRP decoding treats its immediate operand as signed; r=handyman!
arm64 dll interceptor fix, approved for 68.0b4
Attachment #9065562 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•