1552362 - DLL Interceptor: ADRP decoding should treat imm offset as signed

Status: RESOLVED FIXED

(Core :: mozglue, defect, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Right now we're treating it like it's unsigned, so we might not always decode the correct address.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1552362: Ensure that the DLL Interceptor's ADRP decoding treats its immediate operand as signed; r=handyman!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/592cf7293093
Ensure that the DLL Interceptor's ADRP decoding treats its immediate operand as signed; r=handyman

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/592cf7293093

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9065562 [details]
Bug 1552362: Ensure that the DLL Interceptor's ADRP decoding treats its immediate operand as signed; r=handyman!

Beta/Release Uplift Approval Request

• User impact if declined: Potential for crashes/failures on ARM64
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple, straightforward patch
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9065562 [details]
Bug 1552362: Ensure that the DLL Interceptor's ADRP decoding treats its immediate operand as signed; r=handyman!

arm64 dll interceptor fix, approved for 68.0b4

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/02dcc7ca124a