1552379 - camera getUserMedia() from jsfiddle.net broken in Nightly (NotReadableError)

Status: RESOLVED FIXED

(Core :: Permission Manager, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STRs

1. Open https://jsfiddle.net/jib1/r60bzmrs/
2. Allow camera permission

Expected result:
Self view.

Actual result:

NotReadableError: Failed to allocate videosource

Regression range:

7:47.26 INFO: No more inbound revisions, bisection finished.
7:47.26 INFO: Last good revision: 55089d0bf0701221a363514e12592e8bc07405db
7:47.26 INFO: First bad revision: 0229d5353d503441ed11643c8e5e4e90011261b8
7:47.26 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=55089d0bf0701221a363514e12592e8bc07405db&tochange=0229d5353d503441ed11643c8e5e4e90011261b8

Points to Bug 1330467.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Note I have privacy.firstparty.isolate set to false (the default).

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

As I recall NotReadableError can be caused by the parent process permission double-check.

Comment 3

[Johann Hofmann [:johannh]]

Why is this not covered by tests?

[Tracking Requested - why for this release]:
Can't request WebRTC permission in iframes

We could probably fix this, I haven't looked into it yet, but I wonder if landing bug 1330467 right before soft freeze might have been a mistake. Gary, do you think we should try to back out 1330467 while we still can instead of spending our time uplifting fixes to Beta? I'm kind of on the fence here.

Comment 4

[Gary Chen [:xeonchen]]

(In reply to Johann Hofmann [:johannh] from comment #3)

We could probably fix this, I haven't looked into it yet, but I wonder if landing bug 1330467 right before soft freeze might have been a mistake. Gary, do you think we should try to back out 1330467 while we still can instead of spending our time uplifting fixes to Beta? I'm kind of on the fence here.

OK, I agree this was more risky than I expected while the breakage occurs even when FPI is disabled.
I'll request to back out bug 1330467 and re-land into v59.

Comment 5

[Julien Cristau [:jcristau]]

Fixed by backout: https://hg.mozilla.org/mozilla-central/rev/3866561a7bae97a6c9ec3c18174747ec36bba090

Comment 6

[Gary Chen [:xeonchen]]

Attachment: Bug 1552379 - create principal for third party origin;