Closed Bug 1552424 Opened 5 years ago Closed 5 years ago

Go to file is slow when searching for a file

Categories

(DevTools :: Debugger, defect, P3)

68 Branch
defect

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: piotrpalek, Assigned: jlast)

References

(Blocks 1 open bug)

Details

(Whiteboard: [debugger-mvp])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Cmd-P in the debugger, started to search for files

Actual results:

The "Go to file" popup opened, but entering the text phrase was very choppy and slow. In the attached video it's hard to see, because the delay in feedback can't really relayed via a screen recording.
This problem occurs on larger codebases.

Expected results:

Everything should work fast and smooth.

Thanks for filing.

Could you share a performance recording (http://perf-html.io)?

Blocks: dbg-perf

Thanks. We recently made a couple performance improvements in Bug 1547821. My guess is that you are seeing these in 68, but would you be up for testing in Nightly as well?

Also, how many sources do you have in the page? One way to find that out is to open the browser toolbox, select debugger/index.html from the iframe selector and in the console type dbg.selectors.getSourceList().length

Priority: -- → P3
Assignee: nobody → jlaster
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [debugger-mvp]

I've got: 6331 after running dbg.selectors.getSourceList().length. I've also tried on Nightly, but it's the same.

Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b8d12592ce7
Go to file is slow when searching for a file. r=davidwalsh
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Piotr, would you mind re-testing tomorrow on nightly?

Flags: needinfo?(piotrdrag)

Wrong Piotr, I’m afraid.

Flags: needinfo?(piotrdrag)

Is 69.0a1 a version where I can already test? If so it seems to be better, but still slow compared to Chrome

Tested a bit more, it feel way better now, though like noted before, it still visibly needs to "catch up" to what i'm typing. Often the first 2-3 letter feel the slowest (for eg. I type 2 letters, and only after what feels like 0.5s something changes in the list, also the input feels like it gets a little bit stuck after each letter, where on Chrome this feels instant). The "catching up" is probably my biggest complain right now.

Also it seems like a "Files not found" on the list would help visually, right now the list seems to jump around more then it does on Chrome. This is mostly an UX issue imo, but try to compare how this works on Chrome and on Firefox.

Thanks for the feedback! I agree that chrome's is slick.

Have you gotten setup locally? If you have any questions stop by our slack.

Not yet, still on my TODO :) I'll join Slack when I attempt to get the setup running

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: