1552538 - Intermittent browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | A promise chain failed to handle a rejection: win.ownerGlobal.gBrowser is undefined - stack: get hasPinnedTabs@resource://activity-stream/lib/ASRouterTargeting.jsm

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=247060949&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/O66mlZQeTs20BPOfWfIEgQ/runs/0/artifacts/public/logs/live_backing.log

---

15:44:47 INFO - Console message: [JavaScript Error: "Unexpected content-type "text/html;charset=utf-8"" {file: "resource://services-settings/Utils.jsm" line: 91}]
15:44:47 INFO - fetchLatestChanges@resource://services-settings/Utils.jsm:91:15
15:44:47 INFO - asyncsync@resource://services-settings/RemoteSettingsClient.jsm:256:37
15:44:47 INFO - get@resource://services-settings/RemoteSettingsClient.jsm:218:22
15:44:47 INFO - async_getRemoteSettingsMessages@resource://activity-stream/lib/ASRouter.jsm:238:35
15:44:47 INFO - _remoteSettingsLoader@resource://activity-stream/lib/ASRouter.jsm:225:45
15:44:47 INFO - loadMessagesForProvider@resource://activity-stream/lib/ASRouter.jsm:294:26
15:44:47 INFO - loadMessagesFromAllProviders@resource://activity-stream/lib/ASRouter.jsm:533:74
15:44:47 INFO - async*onPrefChange@resource://activity-stream/lib/ASRouter.jsm:428:18
15:44:47 INFO - observe/<@resource://activity-stream/lib/ASRouterPreferences.jsm:134:35
15:44:47 INFO - observe@resource://activity-stream/lib/ASRouterPreferences.jsm:134:21
15:44:47 INFO - _receiveMessageAPI@chrome://mochikit/content/tests/SimpleTest/SpecialPowersObserverAPI.js:356:26
15:44:47 INFO - ChromePowers.prototype._receiveMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:81:30
15:44:47 INFO - ChromePowers.prototype._sendSyncMessage@chrome://mochikit/content/tests/SimpleTest/ChromePowers.js:38:16
15:44:47 INFO - _setPref@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:1409:17
15:44:47 INFO - _applyPrefs@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:1248:14
15:44:47 INFO - _applyPrefs/onPrefActionsApplied/<@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:1227:14
15:44:47 INFO - notify@resource://gre/modules/Timer.jsm:43:17
15:44:47 INFO -
15:44:47 INFO - Console message: [JavaScript Error: "TypeError: win.ownerGlobal.gBrowser is undefined" {file: "resource://activity-stream/lib/ASRouterTargeting.jsm" line: 304}]
15:44:47 INFO - Console message: [JavaScript Error: "TypeError: win.ownerGlobal.gBrowser is undefined" {file: "resource://activity-stream/lib/ASRouterTargeting.jsm" line: 304}]
15:44:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | should receive page visits from existing windows -
15:44:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | should not receive page visits for different domains -
15:44:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | should not receive page visits from existing private windows -
15:44:47 INFO - Buffered messages logged at 15:44:44
15:44:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | should receive page visits from newly opened windows -
15:44:47 INFO - Buffered messages logged at 15:44:45
15:44:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | should not receive page visits from newly opened private windows -
15:44:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | should now not receive page visits from existing windows -
15:44:47 INFO - Buffered messages logged at 15:44:46
15:44:47 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | should now not receive page visits from newly opened windows -
15:44:47 INFO - Buffered messages finished
15:44:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js | A promise chain failed to handle a rejection: win.ownerGlobal.gBrowser is undefined - stack: get hasPinnedTabs@resource://activity-stream/lib/ASRouterTargeting.jsm:304:11

Comment 1

[Natalia Csoregi [:nataliaCs]]

It has started failing with a high frequency once Bug 1552366 landed.

Retriggers range: https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=b3788c8a7cac8b757c02278f7cbea028819964ca&fromchange=8952fe75cb7a65e4f8d718439f6e156ed179c66f&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&group_state=expanded&selectedJob=247239093

:mardak is there any chance you could take a look? Thank you.

Comment 2

[Ed Lee :Mardak]

r1cky, looks like bug 1546429 is the immediate regression with the browser.ini changes:

  browser.newtabpage.activity-stream.asrouter.devtoolsEnabled=true

Although the failing code was added in bug 1528959:

  get hasPinnedTabs() {
…
      if (win.ownerGlobal.gBrowser.visibleTabs.filter(t => t.pinned).length) {

which might get fixed with a simple win.ownerGlobal.gBrowser && (pushing to try now)

k88hudson, the underlying issue seems to be that all messages get loaded from all providers with devtoolsEnabled=true making use of targeting that might not have been expected to be used in these testing conditions, e.g., browser_asrouter_trigger_listeners.js opens up a lot of windows and closes them. I wonder if ASRouter could be made more robust in some way to hide these "test condition" differences so those writing targeting like hasPinnedTabs don't need to worry about odd behaviors such as gBrowser not existing.

Comment 3

[Ed Lee :Mardak]

Pushed a couple try for now:

./mach try fuzzy browser/components/newtab/test/browser/browser_asrouter_trigger_listeners.js -q "'10-64-asan" --rebuild 5

https://treeherder.mozilla.org/#/jobs?repo=try&fromchange=741f8c7c174526e50b1178c66711799e43a480d7&tochange=7b61e43c2e35be6319e14eacff5be29a1aea319a

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1552538 - Check for gBrowser before checking for pinned tabs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a74609752d2
Check for gBrowser before checking for pinned tabs r=r1cky

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4a74609752d2

Comment 7

[Intermittent Failures Robot]

37 failures in 4658 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 34
• mozilla-inbound: 2
• mozilla-central: 1

Platform breakdown:

• windows10-64: 37

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1552538&startday=2019-05-13&endday=2019-05-19&tree=all

Comment 8

[Kate Hudson :k88hudson]

Yeah, having devtoolsEnabled=true might not be the best idea in tests since it doesn't simulate the actual environment of what's being shown to users

Comment 9

[Andrei Oprea [:andreio]]

(In reply to Kate Hudson :k88hudson from comment #8)

Yeah, having devtoolsEnabled=true might not be the best idea in tests since it doesn't simulate the actual environment of what's being shown to users

Going to make that change https://bugzilla.mozilla.org/show_bug.cgi?id=1553450