1552629 - 'Edit and Resend' button is misaligned if there is no 'Referrer Policy' header

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Hengyeow (:tanhengyeow)]

Attachment: intended.jpg

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.157 Safari/537.36

Steps to reproduce:

1. Check out requests with no 'Referrer Policy' header. E.g. Requests from this site.

Actual results:

The 'Edit and Resend' button is placed in an odd position (Refer to results.jpg).

Expected results:

The 'Edit and Resend' button should be flushed to the right at the original width (Refer to intended.jpg).

Comment 1

[Hengyeow (:tanhengyeow)]

Attachment: results.jpg

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report Heng Yeow! I can reproduce this on my machine.

Honza

Comment 3

[Vincent Lequertier]

Hi, can I take this one? :-) I think the problem lies here because summaryEditAndResendBtn is linked to summaryReferrerPolicy.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigned to you, thanks for helping with this bug!
Honza

Comment 5

[Vincent Lequertier]

Attachment: Bug 1552629 - Fix misaligned "Edit and Resend" button in the netmonitor Headers panel;r=Honza

If the "Referrer Policy" header is missing, summaryReferrerPolicy is null,
so summaryEditAndResendBtn contains only the "Edit and Resend" button, making it
misaligned. We fix this by making sure summaryEditAndResendBtn always contains
the last non-null header.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9341602d655c
Fix misaligned "Edit and Resend" button in the netmonitor Headers panel;r=Honza

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9341602d655c

Comment 8

[Cristian Fogel [:cfogel]]

Verified with 69.0 with Windows 10, macOS 10.13, Ubuntu 16.04.