Change bootstrapped extensions to using manifest.json

RESOLVED FIXED in Thunderbird 68.0

Status

task
RESOLVED FIXED
2 months ago
15 days ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

Trunk
Thunderbird 68.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Having to keep support for install.rdf manifests is preventing updates to addons.thunderbird.net from upstream. If we switch bootstrapped add-ons to manifest.json, then at ESR60 EOL we can update the website to a more-recent state.

It would also help if Thunderbird had only one manifest format to deal with.

Attachment #9065851 - Flags: review?(philipp)
Blocks: 1551831
Comment on attachment 9065851 [details] [diff] [review]
1552634-bootstrap-manifest-1.diff

Review of attachment 9065851 [details] [diff] [review]:
-----------------------------------------------------------------

I'm liking all the code removal. I prefer that instead of using bootstrap: true, we use a type attribute set to either bootstrap or xul
Attachment #9065851 - Flags: review?(philipp) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f09d11ed1670
Change bootstrapped extensions to using manifest.json; r=Fallen

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0

I found some further problems I didn't spot earlier.

  • I get asked to restart on installation, but shouldn't.
  • I tried to use a variable that might be null.
Attachment #9065974 - Flags: review?(philipp)
Comment on attachment 9065974 [details] [diff] [review]
1552634-bootstrap-followup-1.diff

Review of attachment 9065974 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with typeof changes discussed on irc
Attachment #9065974 - Flags: review?(philipp) → review+

Hard to tell, but it looks like the follow-up causes:
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/content-tabs/test-install-xpi.js | test-install-xpi.js::test_xpinstall_webext_actually_install
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=06248c61e32429ee1c587154e9ebb976d6266378

Flags: needinfo?(geoff)

I mixed up the two things I fixed when we were talking about it. Damn. And blast. :(

Flags: needinfo?(geoff)
Attachment #9065974 - Attachment is obsolete: true
Attachment #9065997 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/99d648a65b4a
Follow-up: Fix start-up error and unneeded restart message. r=philipp DONTBUILD

Please could we have this change announced on tb-planning or dev.apps.thunderbird? I've just been puzzled as to why this my add-on which is bootstrapped suddenly stopped working in the latest nightly and had to come search for it. Thankfully I knew where to start looking.

Regressions: 1552981

It was announced on maildev, but I'll copy what I wrote there to dev.apps.thunderbird. We have too many mailing lists.

Did this bug make in into tb68? It says so as target, but there are no tracking flags and no commit for beta. I don't see the code in comm-beta and it looks like the push to comm-central was one day too late for merge, so it might need uplifting?

The merge was on the 2019-05-20 during the European afternoon/evening. What makes you think it's not in TB 68? Even the follow-up is there:
https://dxr.mozilla.org/comm-beta/source/mail/base/modules/ExtensionsUI.jsm#672

(In reply to Jorg K (GMT+2) from comment #13)

The merge was on the 2019-05-20 during the European afternoon/evening. What makes you think it's not in TB 68? Even the follow-up is there:
https://dxr.mozilla.org/comm-beta/source/mail/base/modules/ExtensionsUI.jsm#672

I was trying to debug bug 1561270, but couldn't find a regression range and when I looked at my local beta, I couldn't find the changeset either…

You need to log in before you can comment on or make changes to this bug.