Closed Bug 1552652 Opened 5 months ago Closed 5 months ago

dom/media/gtest/MockCubeb.h:436:1: error: control reaches end of non-void function

Categories

(Core :: Audio/Video, defect, P2)

Unspecified
FreeBSD
defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

According to toolkit/moz.configure PulseAudio is used on all Tier3 platforms except OpenBSD which uses sndio.

$ c++ -v
FreeBSD clang version 8.0.0 (tags/RELEASE_800/final 356365) (based on LLVM 8.0.0)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

$ echo "ac_add_options --enable-warnings-as-errors # mimic MOZ_AUTOMATION" >>.mozconfig
$ ./mach build
[...]
In file included from objdir/dom/media/gtest/Unified_cpp_dom_media_gtest0.cpp:20:
In file included from dom/media/gtest/TestAudioCallbackDriver.cpp:18:
dom/media/gtest/MockCubeb.h:436:1: error: control reaches end of non-void function
[-Werror,-Wreturn-type]
}
^
1 error generated.

Attached patch fix (obsolete) — Splinter Review

Can you help landing the fix?

Flags: needinfo?(achronop)

Sure, it's up for review.

Flags: needinfo?(achronop)
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/825113edb81e
Unbreak building tests on Tier3 after bug 1545079. r=padenot
Assignee: nobody → jbeich
Priority: -- → P2
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Attachment #9065874 - Attachment is obsolete: true

Comment on attachment 9065980 [details]
Bug 1552652 - Unbreak building tests on Tier3 after bug 1545079. r?padenot

Beta/Release Uplift Approval Request

  • User impact if declined: Broken build on Tier3 (DragonFly, FreeBSD, NetBSD, OpenBSD, Solaris) unless --disable-tests is added to .mozconfig.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Can only break build.
  • String changes made/needed:

Beta/Release Uplift Approval Request

  • User impact if declined: Broken build on Tier3 (DragonFly, FreeBSD, NetBSD, OpenBSD, Solaris) unless --disable-tests is added to .mozconfig.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Can only break build.
  • String changes made/needed:

Beta/Release Uplift Approval Request

  • User impact if declined: Broken build on Tier3 (DragonFly, FreeBSD, NetBSD, OpenBSD, Solaris) unless --disable-tests is added to .mozconfig.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Can only break build.
  • String changes made/needed:
Attachment #9065980 - Flags: approval-mozilla-beta?

Comment on attachment 9065980 [details]
Bug 1552652 - Unbreak building tests on Tier3 after bug 1545079. r?padenot

build fix for tier3 platforms, approved for 68.0b4

Attachment #9065980 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.