1552652 - dom/media/gtest/MockCubeb.h:436:1: error: control reaches end of non-void function

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jan Beich]

According to toolkit/moz.configure PulseAudio is used on all Tier3 platforms except OpenBSD which uses sndio.

$ c++ -v
FreeBSD clang version 8.0.0 (tags/RELEASE_800/final 356365) (based on LLVM 8.0.0)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

$ echo "ac_add_options --enable-warnings-as-errors # mimic MOZ_AUTOMATION" >>.mozconfig
$ ./mach build
[...]
In file included from objdir/dom/media/gtest/Unified_cpp_dom_media_gtest0.cpp:20:
In file included from dom/media/gtest/TestAudioCallbackDriver.cpp:18:
dom/media/gtest/MockCubeb.h:436:1: error: control reaches end of non-void function
[-Werror,-Wreturn-type]
}
^
1 error generated.

Comment 1

[Jan Beich]

Attachment: fix

Sorry, I can't submit on Phabricator due to bug 1536716.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fa94d993a2d401e3cf416032f91738d4bfeb99d

Comment 2

[Jan Beich]

Can you help landing the fix?

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1552652 - Unbreak building tests on Tier3 after bug 1545079. r?padenot

Comment 4

[Alex Chronopoulos [:achronop]]

Sure, it's up for review.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/825113edb81e
Unbreak building tests on Tier3 after bug 1545079. r=padenot

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/825113edb81e

Comment 7

[Jan Beich]

Comment on attachment 9065980 [details]
Bug 1552652 - Unbreak building tests on Tier3 after bug 1545079. r?padenot

Beta/Release Uplift Approval Request

• User impact if declined: Broken build on Tier3 (DragonFly, FreeBSD, NetBSD, OpenBSD, Solaris) unless --disable-tests is added to .mozconfig.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Can only break build.
• String changes made/needed:

Beta/Release Uplift Approval Request

• User impact if declined: Broken build on Tier3 (DragonFly, FreeBSD, NetBSD, OpenBSD, Solaris) unless --disable-tests is added to .mozconfig.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Can only break build.
• String changes made/needed:

Beta/Release Uplift Approval Request

• User impact if declined: Broken build on Tier3 (DragonFly, FreeBSD, NetBSD, OpenBSD, Solaris) unless --disable-tests is added to .mozconfig.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Can only break build.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9065980 [details]
Bug 1552652 - Unbreak building tests on Tier3 after bug 1545079. r?padenot

build fix for tier3 platforms, approved for 68.0b4

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/93b9f438f639