1552667 - Debug crash when viewing certain message with unknown attachment size in folder not synced for offline use

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Jorg K (CEST = GMT+2)]

I did some debugging, nsImapMockChannel::GetContentLength() hands back an uninitialised mContentLength.

Should be initialised like here in NNTP:
https://searchfox.org/comm-central/rev/95a184ce92612a12cb68ed2d7284a0c1c02cff30/mailnews/news/src/nsNntpMockChannel.cpp#24

The crash is here:
https://searchfox.org/mozilla-central/rev/80a3d06820b31e1d95beb582f15e789cda9f6e03/dom/fetch/FetchDriver.cpp#843
and then here:
https://searchfox.org/mozilla-central/rev/80a3d06820b31e1d95beb582f15e789cda9f6e03/dom/fetch/InternalResponse.h#195

One line fix. I'll also attach the test message.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: Re for performa- invoice.eml

Test data, put this into an IMAP folder not synced for offline use, like the SPAM folder.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1552667-mContentLength.patch

This fixes the debug crash via MOZ_ASSERT() for me.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1552667-mContentLength.patch

Tweaked comment.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1552667-mContentLength.patch

OK, we can also use the M-C constant.

Comment 5

[:aceman]

Comment on attachment 9065892 [details] [diff] [review]
1552667-mContentLength.patch

Review of attachment 9065892 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/865b4199ce94
initialise mContentLength in nsImapMockChannel CTOR to avoid MOZ_ASSERT() later. r=aceman