Closed Bug 1552671 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16911 - Revert "Portals: Add test that portals can't load data, javascript or about URLs."

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 16911 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16911
Details from upstream follow.

Nico Weber <thakis@chromium.org> wrote:

Revert "Portals: Add test that portals can't load data, javascript or about URLs."

This reverts commit 53511d46a059446be0913c208f24b313d050c932.

Reason for revert: The test is failing everywhere, because sheriffbot
reverted https://chromium-review.googlesource.com/c/chromium/src/+/1615499
which was apparently required to let this pass.

Original change's description:

Portals: Add test that portals can't load data, javascript or about URLs.

Bug: 962500
Change-Id: Ib5e275a7f31be3a7e24dfc7bf976b6e2866624fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614703
Commit-Queue: Lucas Gadani \<lfg@chromium.org>
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661004}

TBR=jbroman@chromium.org,lfg@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 962500
Change-Id: I3422d26293a92bfd5653222b1335251a0f398dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619065
Reviewed-by: Nico Weber \<thakis@chromium.org>
Commit-Queue: Nico Weber \<thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661200}

PR 16911 applied with additional changes from upstream: e90af5ab4b2018bc2635e3e3589b89fc7235eb5e
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c563a085e3f1
[wpt PR 16911] - Revert "Portals: Add test that portals can't load data, javascript or about URLs.", a=testonly

https://hg.mozilla.org/mozilla-central/rev/c563a085e3f1

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17457 for changes under testing/web-platform/tests
Whiteboard: [wptsync downstream error] → [wptsync upstream]
Upstream PR merged

Hey there. It appears that we reverted and then relanded this test in Chromium (with automated pushes to GitHub), but then when you tried to resolve this, you pushed the revert into mozilla-central for a second time and then exported that deletion to GitHub for a second time, causing this test to be deleted from Chromium as well.

I'm going to try to revert this latest revert on GitHub to recreate this test, in the hopes that our respective sync bots will copy this properly now.

Link to the WPT PR for that proposed fix.

You need to log in before you can comment on or make changes to this bug.