Closed Bug 1552768 Opened 5 years ago Closed 5 years ago

Input clear icon disappears on hover on Windows

Categories

(Toolkit :: Themes, defect, P1)

Product:
Toolkit
Component:
Themes
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1552768 - Remove hover style rules on Windows for the search input field
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review

Bug 1430165 introduced the same input clear icon for all platforms.
Hovering the icon on Windows makes it disappear probably because of some CSS rule that was not updated.

status-firefox68: --- → affected
Keywords: regression
Priority: -- → P1
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67e2703726da
Remove hover style rules on Windows for the search input field r=nhnt11

https://hg.mozilla.org/mozilla-central/rev/67e2703726da

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Component: Preferences → Themes
Product: Firefox → Toolkit
Target Milestone: Firefox 69 → mozilla69

Please request uplift to beta when you get a chance.

status-firefox67: --- → unaffected
status-firefox-esr60: --- → unaffected
Flags: needinfo?(andrei.br92)

Comment on attachment 9066023 [details]
Bug 1552768 - Remove hover style rules on Windows for the search input field

Beta/Release Uplift Approval Request

  • User impact if declined: Small visual regression in the about:preference page when using the search feature.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small changeset that only affects the styling of the element.
  • String changes made/needed:
Flags: needinfo?(andrei.br92)
Attachment #9066023 - Flags: approval-mozilla-beta?

Comment on attachment 9066023 [details]
Bug 1552768 - Remove hover style rules on Windows for the search input field

regression fix, approved for 68.0b5

Attachment #9066023 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: