1552787 - Log a more verbose error message in the console when a abuse report fails for a client or server submission error

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

To make it easier to investigate issues related to "report submit" errors the AbuseReport's submit method should log a more verbose error message in the browser console.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1552787 - Log a more verbose error message in the console when a abuse report fails for a client or server submission error. r?mixedpuppy!

Depends on D32625

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/412b2751c79a
Log a more verbose error message in the console when a abuse report fails for a client or server submission error. r=mixedpuppy

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/412b2751c79a

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/412b2751c79a

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Marking as qe-verify-, this change is tested as part of the automated tests.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something which should be considered for Beta uplift or can it ride the trains?

Comment 7

[Victor Carciu]

Verified as fixed in latest FF Nightly, Windows 10x64 and macOS 10.14.5

Please see post fix screenshot attached.

Comment 8

[Victor Carciu]

Attachment: Postfix Screenshot

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Is this something which should be considered for Beta uplift or can it ride the trains?

It wouldn't be strictly necessary, but it has been helpful to investigate the reasons behind reports that the API endpoint rejects, and so it would be nice to have it.

I initially marked this as qe-verify- as it is tested in automation and it doesn't fix any particular issue for a user, but QA used the verbose error recently and so I asked them to verify this bug explicitly.

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9067986 [details]
Bug 1552787 - Log a more verbose error message in the console when a abuse report fails for a client or server submission error. r?mixedpuppy!

Beta/Release Uplift Approval Request

• User impact if declined: No visible impact (but it makes easier to provide useful details if a user is not able to report an abuse for a particular extension and wants to report the issue to us on bugzilla).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Not strictly necessary to verify manually, as it is tested in automation, but QA can also verify it on beta, e.g. by changing the abuse report url from about:config ("extensions.abuseReport.url") to point it to a fake API endpoint that always returns an HTTP error on any report submission.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change shouldn't be risky as it is restricted to the abuse report error reporting and tested in automation.
• String changes made/needed:

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9067986 [details]
Bug 1552787 - Log a more verbose error message in the console when a abuse report fails for a client or server submission error. r?mixedpuppy!

debugging help for addon abuse report errors, approved for 68.0b10

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e6fd9ff0ec3

Comment 13

[Victor Carciu]

Verified as fixed in 68.0b12 .

I will attach a postfix screenshot

Comment 14

[Victor Carciu]

Attachment: Postfix Screenshot FF 68.0b12