1552799 - [about:addons] Hide abuse report report action on system and builtin addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Victor Carciu]

Attachment: defaultthemereport.gif

Windows 10x64, FF 68.0a1 (2019-05-19) (64-bit)

Steps to reproduce:
1.In about:addons, try to abuse report a default theme

Expected results:
1.A helpful message should be displayed, saying that default themes cannot be reported

or

2.We can totally hide the abuse reporting for default themes

Actual results:
"There was an error sending the report for <<default theme name>>." is displayed

NOTES:
Please see the attached video

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1552799 - Hide report action on system and builtin addons. r?mstriemer!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c6cc79b65dd
Hide report action on system and builtin addons. r=mstriemer

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7c6cc79b65dd

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7c6cc79b65dd

Comment 5

[Victor Carciu]

Verfied as fixed on Windows 10x64 and macOS 10.13.6 using FF Nightly, buildid 20190610093815.

I will attach a postfix video.

Comment 6

[Victor Carciu]

Attachment: Postfix video

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9067622 [details]
Bug 1552799 - Hide report action on system and builtin addons. r?mstriemer!

Beta/Release Uplift Approval Request

• User impact if declined: The HTML about:addons page will show a report action for builtin and system addons (if they are visible in about:addons, like the default themes).
  Trying to report an abuse of a system or builtin addon will not complete successfully, because the AMO API endpoint does not accept the submitted report and and a generic "report submission error" will be shown to a user.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same STR used to verify it on Nightly (as described in the comment 0 from this issue)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is small (a single line change, only applied to the abuse report action included in the HTML about:addons), and it is covered by additional automated tests (which are actually the biggest part of the patch itself).
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9067622 [details]
Bug 1552799 - Hide report action on system and builtin addons. r?mstriemer!

fix for html about:addons, approved for 68.0b10

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d512a17f5a55

Comment 10

[Victor Carciu]

Verified as fixed in FF Beta 68.0b10 (64-bit) on Win10x64 and macOS 10.15.4

Please see postfix video attached.

Comment 11

[Victor Carciu]

Attachment: Postfix video