[wpt-sync] Sync PR 16918 - Percentage height becomes auto if containing block height is auto.
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync upstream])
Sync web-platform-tests PR 16918 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/16918
Details from upstream follow.
Morten Stenshorne <mstensho@chromium.org> wrote:
Percentage height becomes auto if containing block height is auto.
It's wrong to walk all the way to the root and look for something with a
fixed block size just to determine whether we can collapse through the
block or not. It only matters what the actual block size of the
containing block is.This bug triggered DCHECK failures, because the cached state of
self-collapsing got out of sync with reality, because some ancestor went
from auto-height to fixed-height, a change that shouldn't affect the
descendant at all.Bug: 962175
Change-Id: Ic24d9c46dfa515306563b195487310eedfae9ac3
Reviewed-on: https://chromium-review.googlesource.com/1617833
WPT-Export-Revision: fc2c4ee76838ea922343c8c651b3ae06e304755d
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=91588c278a1db8d8698de5832be0c3986046992f
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d0a3a869d5a38854f8b27d9ef4d9ddbee874ed8
Assignee | ||
Comment 3•5 years ago
|
||
Failed to get results from try push
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c994c2ad464042a523db96ec3d8b4a574c661fff
Assignee | ||
Comment 5•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bb034e916fa8fd97a277eb79751da85511ac426
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/c61bf307f36f [wpt PR 16918] - Percentage height becomes auto if containing block height is auto., a=testonly
Comment 7•5 years ago
|
||
bugherder |
Comment 8•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Description
•