Closed Bug 1552813 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16918 - Percentage height becomes auto if containing block height is auto.

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 16918 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16918
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Percentage height becomes auto if containing block height is auto.

It's wrong to walk all the way to the root and look for something with a
fixed block size just to determine whether we can collapse through the
block or not. It only matters what the actual block size of the
containing block is.

This bug triggered DCHECK failures, because the cached state of
self-collapsing got out of sync with reality, because some ancestor went
from auto-height to fixed-height, a change that shouldn't affect the
descendant at all.

Bug: 962175
Change-Id: Ic24d9c46dfa515306563b195487310eedfae9ac3
Reviewed-on: https://chromium-review.googlesource.com/1617833
WPT-Export-Revision: fc2c4ee76838ea922343c8c651b3ae06e304755d

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c61bf307f36f
[wpt PR 16918] - Percentage height becomes auto if containing block height is auto., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.